Bug 201475

Summary:

[WK2] Add proper layout test support for ephemeral sessions

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, commit-queue, ggaren, koivisto, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=201547

Bug Depends on:

Bug Blocks:

201519, 201522, 201523, 201524, 201546

Attachments:

Description	Flags
WIP Patch	none
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2019-09-04 15:52:19 PDT

Add proper layout test support for ephemeral sessions. testRunner.setPrivateBrowsingEnabled() merely overrides the Page's sessionID in the WebContent process, which is a hack and does not truly enable private browsing.

Attachments
WIP Patch (17.17 KB, patch) 2019-09-04 16:01 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (62.34 KB, patch) 2019-09-05 09:15 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (62.45 KB, patch) 2019-09-05 10:10 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (64.03 KB, patch) 2019-09-05 10:56 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-09-04 16:01:53 PDT

Created attachment 378022 [details] WIP Patch

youenn fablet

Comment 2 2019-09-04 23:38:41 PDT

Comment on attachment 378022 [details] WIP Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378022&action=review > LayoutTests/crypto/subtle/rsa-indexeddb-private.html:2 > <!DOCTYPE html> A lot of tests are suffixed with -private.html and are then expected to run in private browsing mode (see js-test-pre.js). I slightly tend to prefer webkit-test-runner approach but we could also consistently use the name suffix approach. It seems that only a few files would need to be renamed.

Chris Dumez

Comment 3 2019-09-05 09:15:33 PDT

Created attachment 378088 [details] Patch

Chris Dumez

Comment 4 2019-09-05 10:10:05 PDT

Created attachment 378092 [details] Patch

Chris Dumez

Comment 5 2019-09-05 10:56:37 PDT

Created attachment 378097 [details] Patch

WebKit Commit Bot

Comment 6 2019-09-05 14:12:12 PDT

Comment on attachment 378097 [details] Patch Clearing flags on attachment: 378097 Committed r249542: <https://trac.webkit.org/changeset/249542>