Summary: | Flaky Test: fullscreen/full-screen-request-removed-with-raf.html | ||
---|---|---|---|
Product: | WebKit | Reporter: | WebKit Commit Bot <commit-queue> |
Component: | Tools / Tests | Assignee: | WebKit Commit Bot <commit-queue> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | eric.carlson, jer.noble, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=201101 | ||
Bug Depends on: | |||
Bug Blocks: | 50856 | ||
Attachments: |
Description
WebKit Commit Bot
2019-08-27 11:05:32 PDT
Created attachment 377352 [details]
Archive of layout-test-results from webkit-cq-03
Aha, it looks like there's the possibility that 'webkitfullscreenchange' can fire before the first call to rAF(). We may need to re-write the test to not fail if this occurs. The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377341 [details] on bug 201181. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6 Created attachment 377363 [details]
Archive of layout-test-results from webkit-cq-01
The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377350 [details] on bug 201187. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6 Created attachment 377365 [details]
Archive of layout-test-results from webkit-cq-03
The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377283 [details] on bug 201152. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6 Created attachment 377368 [details]
Archive of layout-test-results from webkit-cq-03
This is a new test added with <https://trac.webkit.org/changeset/249147> --- /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fullscreen/full-screen-request-removed-with-raf-expected.txt +++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fullscreen/full-screen-request-removed-with-raf-actual.txt @@ -1,7 +1,6 @@ Tests that fullscreen is not entered if the fullscreen element ancestor is removed with rAF while entering fullscreen. -Removed child element. - +Fullscreen target! SUCCESS END OF TEST Created attachment 377378 [details]
Patch
The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377301 [details] on bug 201165. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6 Created attachment 377382 [details]
Archive of layout-test-results from webkit-cq-03
The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377360 [details] on bug 201163. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6 Created attachment 377387 [details]
Archive of layout-test-results from webkit-cq-03
The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377356 [details] on bug 201191. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6 Created attachment 377419 [details]
Archive of layout-test-results from webkit-cq-01
Comment on attachment 377378 [details] Patch Clearing flags on attachment: 377378 Committed r249201: <https://trac.webkit.org/changeset/249201> All reviewed patches have been landed. Closing bug. |