Bug 201188

Summary: Flaky Test: fullscreen/full-screen-request-removed-with-raf.html
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: Tools / TestsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, jer.noble, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201101
Bug Depends on:    
Bug Blocks: 50856    
Attachments:
Description Flags
Archive of layout-test-results from webkit-cq-03
none
Archive of layout-test-results from webkit-cq-01
none
Archive of layout-test-results from webkit-cq-03
none
Archive of layout-test-results from webkit-cq-03
none
Patch
none
Archive of layout-test-results from webkit-cq-03
none
Archive of layout-test-results from webkit-cq-03
none
Archive of layout-test-results from webkit-cq-01 none

WebKit Commit Bot
Reported 2019-08-27 11:05:32 PDT
This is an automatically generated bug from the commit-queue. fullscreen/full-screen-request-removed-with-raf.html has been flaky on the commit-queue. fullscreen/full-screen-request-removed-with-raf.html was authored by jer.noble@apple.com. https://trac.webkit.org/browser/trunk/LayoutTests/fullscreen/full-screen-request-removed-with-raf.html The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377343 [details] on bug 201182. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6 The bots will update this with information from each new failure. If you believe this bug to be fixed or invalid, feel free to close. The bots will re-open if the flake re-occurs. If you would like to track this test fix with another bug, please close this bug as a duplicate. The bots will follow the duplicate chain when making future comments.
Attachments
Archive of layout-test-results from webkit-cq-03 (3.21 MB, application/zip)
2019-08-27 11:05 PDT, WebKit Commit Bot 		no flags
Details
Archive of layout-test-results from webkit-cq-01 (3.32 MB, application/zip)
2019-08-27 12:29 PDT, WebKit Commit Bot 		no flags
Details
Archive of layout-test-results from webkit-cq-03 (3.31 MB, application/zip)
2019-08-27 12:32 PDT, WebKit Commit Bot 		no flags
Details
Archive of layout-test-results from webkit-cq-03 (3.33 MB, application/zip)
2019-08-27 12:59 PDT, WebKit Commit Bot 		no flags
Details
Patch (2.79 KB, patch)
2019-08-27 13:55 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-03 (3.19 MB, application/zip)
2019-08-27 14:14 PDT, WebKit Commit Bot 		no flags
Details
Archive of layout-test-results from webkit-cq-03 (3.36 MB, application/zip)
2019-08-27 14:41 PDT, WebKit Commit Bot 		no flags
Details
Archive of layout-test-results from webkit-cq-01 (3.19 MB, application/zip)
2019-08-27 20:14 PDT, WebKit Commit Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2019-08-27 11:05:33 PDT
Created attachment 377352 [details] Archive of layout-test-results from webkit-cq-03
Jer Noble
Comment 2 2019-08-27 11:32:13 PDT
Aha, it looks like there's the possibility that 'webkitfullscreenchange' can fire before the first call to rAF(). We may need to re-write the test to not fail if this occurs.
WebKit Commit Bot
Comment 3 2019-08-27 12:29:15 PDT
The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377341 [details] on bug 201181. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6
WebKit Commit Bot
Comment 4 2019-08-27 12:29:16 PDT
Created attachment 377363 [details] Archive of layout-test-results from webkit-cq-01
WebKit Commit Bot
Comment 5 2019-08-27 12:32:15 PDT
The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377350 [details] on bug 201187. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6
WebKit Commit Bot
Comment 6 2019-08-27 12:32:17 PDT
Created attachment 377365 [details] Archive of layout-test-results from webkit-cq-03
WebKit Commit Bot
Comment 7 2019-08-27 12:59:49 PDT
The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377283 [details] on bug 201152. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6
WebKit Commit Bot
Comment 8 2019-08-27 12:59:50 PDT
Created attachment 377368 [details] Archive of layout-test-results from webkit-cq-03
Ryan Haddad
Comment 9 2019-08-27 13:47:57 PDT
This is a new test added with <https://trac.webkit.org/changeset/249147>
Ryan Haddad
Comment 10 2019-08-27 13:51:05 PDT
--- /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fullscreen/full-screen-request-removed-with-raf-expected.txt +++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fullscreen/full-screen-request-removed-with-raf-actual.txt @@ -1,7 +1,6 @@ Tests that fullscreen is not entered if the fullscreen element ancestor is removed with rAF while entering fullscreen. -Removed child element. - +Fullscreen target! SUCCESS END OF TEST
Jer Noble
Comment 11 2019-08-27 13:55:37 PDT
Created attachment 377378 [details] Patch
WebKit Commit Bot
Comment 12 2019-08-27 14:14:13 PDT
The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377301 [details] on bug 201165. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6
WebKit Commit Bot
Comment 13 2019-08-27 14:14:14 PDT
Created attachment 377382 [details] Archive of layout-test-results from webkit-cq-03
WebKit Commit Bot
Comment 14 2019-08-27 14:41:50 PDT
The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377360 [details] on bug 201163. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6
WebKit Commit Bot
Comment 15 2019-08-27 14:41:51 PDT
Created attachment 377387 [details] Archive of layout-test-results from webkit-cq-03
WebKit Commit Bot
Comment 16 2019-08-27 20:14:50 PDT
The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377356 [details] on bug 201191. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6
WebKit Commit Bot
Comment 17 2019-08-27 20:14:51 PDT
Created attachment 377419 [details] Archive of layout-test-results from webkit-cq-01
WebKit Commit Bot
Comment 18 2019-08-28 09:28:34 PDT
Comment on attachment 377378 [details] Patch Clearing flags on attachment: 377378 Committed r249201: <https://trac.webkit.org/changeset/249201>
WebKit Commit Bot
Comment 19 2019-08-28 09:28:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 20 2019-08-28 09:29:45 PDT
<rdar://problem/54793843>
Note You need to log in before you can comment on or make changes to this bug.