Bug 182571

Summary:

Flaky Test: media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html

Product:

WebKit

Reporter:

WebKit Commit Bot <commit-queue>

Component:

Tools / Tests

Assignee:

Peng Liu <peng.liu6>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, ews-watchlist, glenn, graouts, jacob_uphoff, jenner, jer.noble, jlewis3, lforschler, peng.liu6, philipj, ryanhaddad, sergio, sroberts

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=222134

Bug Depends on:

Bug Blocks:

50856

Attachments:

Description	Flags
Archive of layout-test-results from webkit-cq-01	none
Archive of layout-test-results from webkit-cq-01	none
Patch	none
Patch	none
Add an explicit timeout in the test to debug the flaky timeout	none
Patch	none

WebKit Commit Bot

Reported 2018-02-07 08:13:00 PST

This is an automatically generated bug from the commit-queue. media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html has been flaky on the commit-queue. media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html was authored by graouts@apple.com and ryanhaddad@apple.com. https://trac.webkit.org/browser/trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html The commit-queue just saw media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html flake (test timed out) while processing attachment 333282 [details] on bug 182568. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.12.6 The bots will update this with information from each new failure. If you believe this bug to be fixed or invalid, feel free to close. The bots will re-open if the flake re-occurs. If you would like to track this test fix with another bug, please close this bug as a duplicate. The bots will follow the duplicate chain when making future comments.

Attachments
Archive of layout-test-results from webkit-cq-01 (2.25 MB, application/zip) 2018-02-07 08:13 PST, WebKit Commit Bot	no flags	Details
Archive of layout-test-results from webkit-cq-01 (2.25 MB, application/zip) 2018-02-08 12:49 PST, WebKit Commit Bot	no flags	Details
Patch (1.35 KB, patch) 2019-02-07 15:13 PST, Shawn Roberts	no flags	Details Formatted Diff Diff
Patch (2.30 KB, patch) 2019-02-07 15:25 PST, Shawn Roberts	no flags	Details Formatted Diff Diff
Add an explicit timeout in the test to debug the flaky timeout (1.62 KB, patch) 2020-05-18 22:43 PDT, Peng Liu	no flags	Details Formatted Diff Diff
Patch (4.90 KB, patch) 2021-02-25 16:15 PST, Peng Liu	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

WebKit Commit Bot

Comment 1 2018-02-07 08:13:01 PST

Created attachment 333285 [details] Archive of layout-test-results from webkit-cq-01

Ryan Haddad

Comment 2 2018-02-08 11:33:00 PST

This test is a flaky timeout on High Sierra Debug WK1 and Sierra Release WK1. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Ftracks-support%2Ftracks-support-show-panel-fullscreen.html

WebKit Commit Bot

Comment 3 2018-02-08 12:49:23 PST

The commit-queue just saw media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html flake (test timed out) while processing attachment 333402 [details] on bug 182607. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.12.6

WebKit Commit Bot

Comment 4 2018-02-08 12:49:24 PST

Created attachment 333411 [details] Archive of layout-test-results from webkit-cq-01

Ryan Haddad

Comment 5 2018-02-08 13:13:30 PST

Marked test as flaky on WK1 in https://trac.webkit.org/r228291

Shawn Roberts

Comment 6 2019-02-07 15:11:51 PST

updated to mark flaky on all of Mac as it's now affecting Mojave and WK2

Shawn Roberts

Comment 7 2019-02-07 15:13:56 PST

Created attachment 361460 [details] Patch

EWS Watchlist

Comment 8 2019-02-07 15:15:50 PST

Attachment 361460 [details] did not pass style-queue: ERROR: LayoutTests/platform/mac/TestExpectations:1803: Unrecognized modifier 'mac' [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1803: Unrecognized modifier 'mac' [test/expectations] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Shawn Roberts

Comment 9 2019-02-07 15:25:45 PST

Created attachment 361461 [details] Patch

Alexey Proskuryakov

Comment 10 2020-01-22 22:57:03 PST

*** Bug 206631 has been marked as a duplicate of this bug. ***

Alexey Proskuryakov

Comment 11 2020-01-22 22:57:18 PST

<rdar://problem/58817580>

Jacob Uphoff

Comment 12 2020-04-08 10:08:07 PDT

Set expectations to include wk2. https://trac.webkit.org/changeset/259723/webkit

Peng Liu

Comment 13 2020-05-11 14:17:02 PDT

*** This bug has been marked as a duplicate of bug 211645 ***

Ryan Haddad

Comment 14 2020-05-14 12:33:07 PDT

Reopening because this test is still a flaky timeout on the bots after the fix for bug 211645

Ryan Haddad

Comment 15 2020-05-14 12:34:08 PDT

(In reply to Ryan Haddad from comment #14) > Reopening because this test is still a flaky timeout on the bots after the > fix for bug 211645 Specifically, it continues to time out on Catalina and Mojave Debug queues.

Ryan Haddad

Comment 16 2020-05-14 14:40:34 PDT

I marked it as flaky again in r261704.

Peng Liu

Comment 17 2020-05-18 22:43:19 PDT

Created attachment 399713 [details] Add an explicit timeout in the test to debug the flaky timeout

EWS

Comment 18 2020-05-18 23:18:51 PDT

Committed r261852: <https://trac.webkit.org/changeset/261852> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399713 [details].

Peng Liu

Comment 19 2020-05-20 11:37:02 PDT

Reopen this bug to investigate the failure instead of timeout on bots after r261852.

Peng Liu

Comment 20 2020-05-20 16:57:36 PDT

The diff is below: @@ -9,10 +9,7 @@ PASS internals.shadowRoot(media).querySelector("button.tracks") became different from null PASS internals.shadowRoot(media).querySelector("button.tracks").getBoundingClientRect().width became different from 0 PASS internals.shadowRoot(media).querySelector("button.tracks").getBoundingClientRect().right became 582 -PASS internals.shadowRoot(media).querySelector('.tracks-panel') became different from null -PASS internals.shadowRoot(media).querySelector('.tracks-panel').style.right is "218px" -PASS internals.shadowRoot(media).querySelector('.tracks-panel').style.bottom is "101px" - +FAIL: did not end fast enough PASS successfullyParsed is true TEST COMPLETE

Robert Jenner

Comment 21 2021-02-18 15:28:05 PST

Timeout expectation set in previous patch was causing the test to be more flakey. Removed timeout test expectation from log in bug: https://bugs.webkit.org/show_bug.cgi?id=222117

Peng Liu

Comment 22 2021-02-25 13:59:06 PST

*** This bug has been marked as a duplicate of bug 169158 ***

Peng Liu

Comment 23 2021-02-25 14:02:22 PST

It was a mistake to mark this bug as a duplicate.

Peng Liu

Comment 24 2021-02-25 16:15:42 PST

Created attachment 421581 [details] Patch

EWS

Comment 25 2021-02-26 14:40:02 PST

Committed r273591: <https://commits.webkit.org/r273591> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421581 [details].

Note You need to log in before you can comment on or make changes to this bug.