Summary: | Flaky Test: media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Commit Bot <commit-queue> | ||||||||||||||
Component: | Tools / Tests | Assignee: | Peng Liu <peng.liu6> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, graouts, jacob_uphoff, jenner, jer.noble, jlewis3, lforschler, peng.liu6, philipj, ryanhaddad, sergio, sroberts | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=222134 | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 50856 | ||||||||||||||||
Attachments: |
|
Description
WebKit Commit Bot
2018-02-07 08:13:00 PST
Created attachment 333285 [details]
Archive of layout-test-results from webkit-cq-01
This test is a flaky timeout on High Sierra Debug WK1 and Sierra Release WK1. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Ftracks-support%2Ftracks-support-show-panel-fullscreen.html The commit-queue just saw media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html flake (test timed out) while processing attachment 333402 [details] on bug 182607. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.12.6 Created attachment 333411 [details]
Archive of layout-test-results from webkit-cq-01
Marked test as flaky on WK1 in https://trac.webkit.org/r228291 updated to mark flaky on all of Mac as it's now affecting Mojave and WK2 Created attachment 361460 [details]
Patch
Attachment 361460 [details] did not pass style-queue:
ERROR: LayoutTests/platform/mac/TestExpectations:1803: Unrecognized modifier 'mac' [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1803: Unrecognized modifier 'mac' [test/expectations] [5]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 361461 [details]
Patch
*** Bug 206631 has been marked as a duplicate of this bug. *** Set expectations to include wk2. https://trac.webkit.org/changeset/259723/webkit *** This bug has been marked as a duplicate of bug 211645 *** Reopening because this test is still a flaky timeout on the bots after the fix for bug 211645 (In reply to Ryan Haddad from comment #14) > Reopening because this test is still a flaky timeout on the bots after the > fix for bug 211645 Specifically, it continues to time out on Catalina and Mojave Debug queues. I marked it as flaky again in r261704. Created attachment 399713 [details]
Add an explicit timeout in the test to debug the flaky timeout
Committed r261852: <https://trac.webkit.org/changeset/261852> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399713 [details]. Reopen this bug to investigate the failure instead of timeout on bots after r261852. The diff is below: @@ -9,10 +9,7 @@ PASS internals.shadowRoot(media).querySelector("button.tracks") became different from null PASS internals.shadowRoot(media).querySelector("button.tracks").getBoundingClientRect().width became different from 0 PASS internals.shadowRoot(media).querySelector("button.tracks").getBoundingClientRect().right became 582 -PASS internals.shadowRoot(media).querySelector('.tracks-panel') became different from null -PASS internals.shadowRoot(media).querySelector('.tracks-panel').style.right is "218px" -PASS internals.shadowRoot(media).querySelector('.tracks-panel').style.bottom is "101px" - +FAIL: did not end fast enough PASS successfullyParsed is true TEST COMPLETE Timeout expectation set in previous patch was causing the test to be more flakey. Removed timeout test expectation from log in bug: https://bugs.webkit.org/show_bug.cgi?id=222117 *** This bug has been marked as a duplicate of bug 169158 *** It was a mistake to mark this bug as a duplicate. Created attachment 421581 [details]
Patch
Committed r273591: <https://commits.webkit.org/r273591> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421581 [details]. |