Bug 155322

Summary:

Tracking bug for CG asynchronous image decoding

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Images

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, dino, japhet, jonlee, kondapallykalyan, rniwa, roger_fong, sam, simon.fraser, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

165040, 169396, 155412, 155422, 155444, 155456, 155498, 155546, 155566, 155997, 156690, 156766, 157750, 158684, 159679, 159699, 159721, 159795, 159819, 161566, 161705, 162478, 163298, 163410, 164417, 165039, 165131, 168814

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews116 for mac-yosemite	none
Patch	none
Patch	none
Archive of layout-test-results from ews100 for mac-yosemite	none
Archive of layout-test-results from ews117 for mac-yosemite	none
Patch	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews114 for mac-yosemite	none
Patch	none
Archive of layout-test-results from ews100 for mac-yosemite	none
Archive of layout-test-results from ews116 for mac-yosemite	none
Patch	none
Patch	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews115 for mac-yosemite	none
Patch	none
Archive of layout-test-results from ews100 for mac-yosemite	none
Patch	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews116 for mac-yosemite	none
Patch	none
Archive of layout-test-results from ews115 for mac-yosemite	none
Patch	none

Description Said Abou-Hallawa 2016-03-10 14:04:13 PST

Tracking bug for forking the image decoding into two separate paths:

1. Synchronous: This is the current implementation where the image decoding usually happens in the whippet thread when an image drawing command is pushed into the CG context.
2. Asynchronous: This is a new mode where an image decoding will start immediately after receiving the first chunk of the encoded image date. And to not block the main thread, this image decoding has to run on a separate thread.

Comment 1 Said Abou-Hallawa 2016-03-11 19:24:23 PST

Created attachment 273794 [details]
Patch

Comment 2 Said Abou-Hallawa 2016-03-11 19:26:43 PST

This patch is not for review. I am planning to split it into sub patches for review. The purpose of this patch is to fix the build breaks and the test failures.

Comment 3 Said Abou-Hallawa 2016-03-11 19:28:59 PST

Created attachment 273795 [details]
Patch

Comment 4 Said Abou-Hallawa 2016-03-11 19:35:35 PST

Created attachment 273797 [details]
Patch

Comment 5 Said Abou-Hallawa 2016-03-11 20:12:32 PST

Created attachment 273799 [details]
Patch

Comment 6 Said Abou-Hallawa 2016-03-11 20:38:20 PST

Created attachment 273800 [details]
Patch

Comment 7 Said Abou-Hallawa 2016-03-11 20:42:19 PST

Created attachment 273801 [details]
Patch

Comment 8 Said Abou-Hallawa 2016-03-11 21:35:01 PST

Created attachment 273802 [details]
Patch

Comment 9 Said Abou-Hallawa 2016-03-11 22:05:16 PST

Created attachment 273805 [details]
Patch

Comment 10 Said Abou-Hallawa 2016-03-11 22:42:41 PST

Created attachment 273810 [details]
Patch

Comment 11 Build Bot 2016-03-11 23:24:56 PST

Comment on attachment 273810 [details]
Patch

Attachment 273810 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/964479

New failing tests:
transitions/extra-transition.html
svg/carto.net/scrollbar.svg

Comment 12 Build Bot 2016-03-11 23:25:01 PST

Created attachment 273816 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 13 Build Bot 2016-03-12 00:30:27 PST

Comment on attachment 273810 [details]
Patch

Attachment 273810 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/964779

New failing tests:
svg/carto.net/scrollbar.svg

Comment 14 Build Bot 2016-03-12 00:30:33 PST

Created attachment 273820 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 15 Said Abou-Hallawa 2016-03-12 02:18:47 PST

Created attachment 273826 [details]
Patch

Comment 16 Said Abou-Hallawa 2016-03-12 02:26:35 PST

Created attachment 273828 [details]
Patch

Comment 17 Build Bot 2016-03-12 03:20:44 PST

Comment on attachment 273828 [details]
Patch

Attachment 273828 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/965531

New failing tests:
transitions/extra-transition.html

Comment 18 Build Bot 2016-03-12 03:20:50 PST

Created attachment 273831 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 19 Build Bot 2016-03-12 05:37:06 PST

Comment on attachment 273828 [details]
Patch

Attachment 273828 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/965991

New failing tests:
transitions/extra-transition.html
svg/carto.net/scrollbar.svg

Comment 20 Build Bot 2016-03-12 05:37:10 PST

Created attachment 273834 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 21 Said Abou-Hallawa 2016-03-12 09:19:50 PST

Created attachment 273838 [details]
Patch

Comment 22 Build Bot 2016-03-12 10:11:41 PST

Comment on attachment 273838 [details]
Patch

Attachment 273838 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/967075

New failing tests:
transitions/extra-transition.html
svg/carto.net/scrollbar.svg

Comment 23 Build Bot 2016-03-12 10:11:46 PST

Created attachment 273841 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 24 Build Bot 2016-03-12 10:24:00 PST

Comment on attachment 273838 [details]
Patch

Attachment 273838 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/967089

New failing tests:
transitions/extra-transition.html
svg/carto.net/scrollbar.svg

Comment 25 Build Bot 2016-03-12 10:24:04 PST

Created attachment 273842 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 26 Said Abou-Hallawa 2016-03-12 13:34:46 PST

Created attachment 273847 [details]
Patch

Comment 27 Build Bot 2016-03-12 14:29:09 PST

Comment on attachment 273847 [details]
Patch

Attachment 273847 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/967979

New failing tests:
transitions/extra-transition.html
svg/carto.net/scrollbar.svg

Comment 28 Build Bot 2016-03-12 14:29:13 PST

Created attachment 273851 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 29 Build Bot 2016-03-12 14:50:47 PST

Comment on attachment 273847 [details]
Patch

Attachment 273847 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/968016

New failing tests:
transitions/extra-transition.html
svg/carto.net/scrollbar.svg

Comment 30 Build Bot 2016-03-12 14:50:53 PST

Created attachment 273855 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 31 Said Abou-Hallawa 2016-03-12 20:22:23 PST

Created attachment 273866 [details]
Patch

Comment 32 Said Abou-Hallawa 2016-03-12 20:52:27 PST

Created attachment 273867 [details]
Patch

Comment 33 Build Bot 2016-03-12 21:46:11 PST

Comment on attachment 273867 [details]
Patch

Attachment 273867 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/969595

New failing tests:
fast/images/gif-large-checkerboard.html
transitions/extra-transition.html
svg/carto.net/scrollbar.svg

Comment 34 Build Bot 2016-03-12 21:46:16 PST

Created attachment 273869 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 35 Build Bot 2016-03-12 22:11:18 PST

Comment on attachment 273867 [details]
Patch

Attachment 273867 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/969610

New failing tests:
transitions/extra-transition.html

Comment 36 Build Bot 2016-03-12 22:11:22 PST

Created attachment 273870 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 37 Said Abou-Hallawa 2016-03-12 22:12:39 PST

Created attachment 273871 [details]
Patch

Comment 38 Build Bot 2016-03-12 23:06:34 PST

Comment on attachment 273871 [details]
Patch

Attachment 273871 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/969872

New failing tests:
transitions/extra-transition.html

Comment 39 Build Bot 2016-03-12 23:06:41 PST

Created attachment 273872 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 40 Said Abou-Hallawa 2016-03-12 23:09:29 PST

Created attachment 273873 [details]
Patch

Comment 41 Build Bot 2016-03-13 00:02:06 PST

Comment on attachment 273873 [details]
Patch

Attachment 273873 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/970068

New failing tests:
svg/carto.net/scrollbar.svg

Comment 42 Build Bot 2016-03-13 00:02:12 PST

Created attachment 273877 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 43 Build Bot 2016-03-13 00:23:33 PST

Comment on attachment 273873 [details]
Patch

Attachment 273873 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/970101

New failing tests:
transitions/extra-transition.html

Comment 44 Build Bot 2016-03-13 00:23:40 PST

Created attachment 273878 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 45 Said Abou-Hallawa 2016-03-13 00:59:20 PST

Created attachment 273880 [details]
Patch

Comment 46 Build Bot 2016-03-13 01:55:12 PST

Comment on attachment 273880 [details]
Patch

Attachment 273880 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/970432

New failing tests:
transitions/extra-transition.html
fast/images/gif-short-app-extension-string.html

Comment 47 Build Bot 2016-03-13 01:55:17 PST

Created attachment 273883 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 48 Said Abou-Hallawa 2016-03-13 03:51:59 PDT

Created attachment 273888 [details]
Patch

Comment 49 Said Abou-Hallawa 2017-07-24 11:03:46 PDT

The asynchronous image decoding feature was implemented and has been enabled in WebKit. What is left here is fixing regular bugs. So resolve this bug as Fixed.