Bug 95582 – [Gtk] Add Battery Status API support

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[José Dapena Paz]

Battery Status API allows web applications to track power status of the device. It allows to behave different depending on that (i.e. avoid expensive calculations or polling if battery is low and discharging).

Specs: http://dvcs.w3.org/hg/dap/raw-file/tip/battery/Overview.html

[José Dapena Paz]

Created attachment 162059 [details]
Patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Early Warning System Bot]

Comment on attachment 162059 [details]
Patch

Attachment 162059 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13743569

[Early Warning System Bot]

Comment on attachment 162059 [details]
Patch

Attachment 162059 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13757285

[Build Bot]

Comment on attachment 162059 [details]
Patch

Attachment 162059 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13739629

[Build Bot]

Comment on attachment 162059 [details]
Patch

Attachment 162059 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13744616

[Zan Dobersek]

Can we get this work moving again? I can help if help is needed.

[Philippe Normand]

Comment on attachment 162059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162059&action=review

> Source/WebCore/ChangeLog:13
> +        Test are disabled, as there is a linking issue related to
> +        WebCoreInternals.

It'd be nice to figure this issue out. Also, not sure we want to add new features in WK1 at this point :/

[Zan Dobersek]

Comment on attachment 162059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162059&action=review

The specification is a candidate recommendation so I think it would be great if we can get the implementation up and working.

>> Source/WebCore/ChangeLog:13
>> +        WebCoreInternals.
> 
> It'd be nice to figure this issue out. Also, not sure we want to add new features in WK1 at this point :/

I think this is simply a matter of exporting the undefined symbols, nothing uncommon really.

[Zan Dobersek]

(In reply to comment #9)
> The specification is a candidate recommendation so I think it would be great if we can get the implementation up and working.
> 

Link to the specification:
http://www.w3.org/TR/battery-status/

[ChangSeok Oh]

Oops. I didn't notice this movement supporting BatteryStatus before.. :p
What's going on this? 
I've also worked a patch for this feature. If you guys don't mind, I'd like to post my patch somewhere. :)

[Zan Dobersek]

Shame about the duplicated work.

My set of patches is complete, but still requires reviewing. The patches are spread in the bugs that are blocking this one.

[Zan Dobersek]

Aaand it's done.

[ChangSeok Oh]

(In reply to comment #13)
> Aaand it's done.

Zan, great works! :)