Bug 95582 - [Gtk] Add Battery Status API support
Summary: [Gtk] Add Battery Status API support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Gtk (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: José Dapena Paz
URL:
Keywords: Gtk, LayoutTestFailure
Depends on: 95937 115628 115718 115719 115720 125453
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-31 09:09 PDT by José Dapena Paz
Modified: 2013-12-12 00:06 PST (History)
9 users (show)

See Also:


Attachments
Patch (44.18 KB, patch)
2012-09-04 10:50 PDT, José Dapena Paz
pnormand: review-
webkit-ews: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description José Dapena Paz 2012-08-31 09:09:22 PDT
Battery Status API allows web applications to track power status of the device. It allows to behave different depending on that (i.e. avoid expensive calculations or polling if battery is low and discharging).

Specs: http://dvcs.w3.org/hg/dap/raw-file/tip/battery/Overview.html
Comment 1 José Dapena Paz 2012-09-04 10:50:52 PDT
Created attachment 162059 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-04 10:54:49 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Early Warning System Bot 2012-09-04 11:13:55 PDT
Comment on attachment 162059 [details]
Patch

Attachment 162059 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13743569
Comment 4 Early Warning System Bot 2012-09-04 11:17:24 PDT
Comment on attachment 162059 [details]
Patch

Attachment 162059 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13757285
Comment 5 Build Bot 2012-09-04 11:17:33 PDT
Comment on attachment 162059 [details]
Patch

Attachment 162059 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13739629
Comment 6 Build Bot 2012-09-04 12:19:08 PDT
Comment on attachment 162059 [details]
Patch

Attachment 162059 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13744616
Comment 7 Zan Dobersek 2013-01-24 08:55:46 PST
Can we get this work moving again? I can help if help is needed.
Comment 8 Philippe Normand 2013-04-12 12:15:22 PDT
Comment on attachment 162059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162059&action=review

> Source/WebCore/ChangeLog:13
> +        Test are disabled, as there is a linking issue related to
> +        WebCoreInternals.

It'd be nice to figure this issue out. Also, not sure we want to add new features in WK1 at this point :/
Comment 9 Zan Dobersek 2013-04-13 10:05:00 PDT
Comment on attachment 162059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162059&action=review

The specification is a candidate recommendation so I think it would be great if we can get the implementation up and working.

>> Source/WebCore/ChangeLog:13
>> +        WebCoreInternals.
> 
> It'd be nice to figure this issue out. Also, not sure we want to add new features in WK1 at this point :/

I think this is simply a matter of exporting the undefined symbols, nothing uncommon really.
Comment 10 Zan Dobersek 2013-04-13 10:06:28 PDT
(In reply to comment #9)
> The specification is a candidate recommendation so I think it would be great if we can get the implementation up and working.
> 

Link to the specification:
http://www.w3.org/TR/battery-status/
Comment 11 ChangSeok Oh 2013-08-23 10:50:32 PDT
Oops. I didn't notice this movement supporting BatteryStatus before.. :p
What's going on this? 
I've also worked a patch for this feature. If you guys don't mind, I'd like to post my patch somewhere. :)
Comment 12 Zan Dobersek 2013-08-23 11:09:09 PDT
Shame about the duplicated work.

My set of patches is complete, but still requires reviewing. The patches are spread in the bugs that are blocking this one.
Comment 13 Zan Dobersek 2013-12-11 10:22:22 PST
Aaand it's done.
Comment 14 ChangSeok Oh 2013-12-12 00:06:14 PST
(In reply to comment #13)
> Aaand it's done.

Zan, great works! :)