WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
115718
[GTK] Plumb the Automake build system for the Battery Status API feature
https://bugs.webkit.org/show_bug.cgi?id=115718
Summary
[GTK] Plumb the Automake build system for the Battery Status API feature
Zan Dobersek
Reported
2013-05-07 01:54:53 PDT
[GTK] Plumb the Automake build system for the Battery Status API feature
Attachments
Patch
(12.04 KB, patch)
2013-05-07 02:14 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Patch
(12.17 KB, patch)
2013-05-07 02:49 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2013-05-07 02:14:53 PDT
Created
attachment 200883
[details]
Patch
Zan Dobersek
Comment 2
2013-05-07 02:49:37 PDT
Created
attachment 200884
[details]
Patch
Martin Robinson
Comment 3
2013-05-07 08:17:07 PDT
Comment on
attachment 200884
[details]
Patch Okay. I wonder if we could share the battery support with EFL? At this point, I don't think it makes sense to add too much more GTK+ specific code.
Zan Dobersek
Comment 4
2013-05-07 08:48:16 PDT
In what context are you referencing the GTK+-specific code? Do you mean the Autotools build system? The EFL implementation of the battery provider uses an EFL wrapper around the UPower DBus interface, so there's not much to be shared there unless we step out of the comfort zone and start querying the DBus ourselves in a shareable way.
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/efl/BatteryProviderEfl.cpp
https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=2&cad=rja&ved=0CDoQFjAB&url=http%3A%2F%2Fdocs.enlightenment.org%2Fauto%2Fe_dbus%2FE__Ukit_8h.html&ei=cyGJUau7DYL_4QSr2YHQCQ&usg=AFQjCNHszLtqG00qWgmE_b8HXYmqG8y8Ow&sig2=UGq-mriEsS__Wi2cUbU-lA&bvm=bv.45960087,d.bGE
Zan Dobersek
Comment 5
2013-05-08 12:39:02 PDT
Comment on
attachment 200884
[details]
Patch Clearing flags on attachment: 200884 Committed
r149759
: <
http://trac.webkit.org/changeset/149759
>
Zan Dobersek
Comment 6
2013-05-08 12:39:10 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug