Bug 115718 - [GTK] Plumb the Automake build system for the Battery Status API feature
Summary: [GTK] Plumb the Automake build system for the Battery Status API feature
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 95582 115719 115720
  Show dependency tree / graph
 
Reported: 2013-05-07 01:54 PDT by Zan Dobersek
Modified: 2013-05-08 12:39 PDT (History)
4 users (show)

See Also:

Attachments
Patch (12.04 KB, patch)
2013-05-07 02:14 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (12.17 KB, patch)
2013-05-07 02:49 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-05-07 01:54:53 PDT 
[GTK] Plumb the Automake build system for the Battery Status API feature
Comment 1 Zan Dobersek 2013-05-07 02:14:53 PDT 
Created attachment 200883 [details]
Patch
Comment 2 Zan Dobersek 2013-05-07 02:49:37 PDT 
Created attachment 200884 [details]
Patch
Comment 3 Martin Robinson 2013-05-07 08:17:07 PDT 
Comment on attachment 200884 [details]
Patch

Okay. I wonder if we could share the battery support with EFL? At this point, I don't think it makes sense to add too much more GTK+ specific code.
Comment 4 Zan Dobersek 2013-05-07 08:48:16 PDT 
In what context are you referencing the GTK+-specific code? Do you mean the Autotools build system?

The EFL implementation of the battery provider uses an EFL wrapper around the UPower DBus interface, so there's not much to be shared there unless we step out of the comfort zone and start querying the DBus ourselves in a shareable way.
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/efl/BatteryProviderEfl.cpp
https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=2&cad=rja&ved=0CDoQFjAB&url=http%3A%2F%2Fdocs.enlightenment.org%2Fauto%2Fe_dbus%2FE__Ukit_8h.html&ei=cyGJUau7DYL_4QSr2YHQCQ&usg=AFQjCNHszLtqG00qWgmE_b8HXYmqG8y8Ow&sig2=UGq-mriEsS__Wi2cUbU-lA&bvm=bv.45960087,d.bGE
Comment 5 Zan Dobersek 2013-05-08 12:39:02 PDT 
Comment on attachment 200884 [details]
Patch

Clearing flags on attachment: 200884

Committed r149759: <http://trac.webkit.org/changeset/149759>
Comment 6 Zan Dobersek 2013-05-08 12:39:10 PDT 
All reviewed patches have been landed.  Closing bug.