Bug 92636 – [Qt][WK1] REGRESSION(r123988) It made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[János Badics]

r123988 made this test fail on WebKit1. The diff is the following:

--- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/writing-mode/flipped-blocks-hit-test-line-edges-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/writing-mode/flipped-blocks-hit-test-line-edges-actual.txt 
@@ -7,6 +7,6 @@
 PASS: offset at (160,26) was 26.
 PASS: offset at (60,25) was 24.
 PASS: offset at (160,25) was 26.
-PASS: offset at (60,24) was 26.
+FAIL: offset at (60,24) was 24. Expected 26.
 PASS: offset at (160,24) was 26.
 
You can see the original bug at
​https://bugs.webkit.org/show_bug.cgi?id=92597

[Zoltan Arvai]

*** Bug 92639 has been marked as a duplicate of this bug. ***

[Csaba Osztrogonác]

Skipped by https://trac.webkit.org/changeset/124018, please unskip it with the proper fix.

The test is failing because of the different selection mode used in some non-OS X ports.

[Marcelo Lira]

Created attachment 165677 [details]
Patch

[Ryosuke Niwa]

Does the test pass now? Why can we unskip the test?

[Csaba Osztrogonác]

Comment on attachment 165677 [details]
Patch

It seems it passes now, so let's unskip it.

[WebKit Review Bot]

Comment on attachment 165677 [details]
Patch

Clearing flags on attachment: 165677

Committed r129606: <http://trac.webkit.org/changeset/129606>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.