Bug 92597 - In flipped blocks, a point on the top edge of a text box is considered outside the box (and vice versa)
Summary: In flipped blocks, a point on the top edge of a text box is considered outsid...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on: 92636 92662
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-29 14:11 PDT by mitz
Modified: 2012-07-30 11:46 PDT (History)
7 users (show)

See Also:


Attachments
When comparing y coordinates in flipped text, make strict inequalities non-strict and vice versa (8.74 KB, patch)
2012-07-29 14:19 PDT, mitz
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2012-07-29 14:11:43 PDT
This is like bug 92593 but for text boxes. When you drag to select across text in a flipped block, when the mouse pointer is at the top of the line, it’s already selecting the line above.
Comment 1 mitz 2012-07-29 14:19:43 PDT
Created attachment 155182 [details]
When comparing y coordinates in flipped text, make strict inequalities non-strict and vice versa
Comment 2 Ryosuke Niwa 2012-07-29 14:54:27 PDT
Comment on attachment 155182 [details]
When comparing y coordinates in flipped text, make strict inequalities non-strict and vice versa

Makes sense.
Comment 3 Ryosuke Niwa 2012-07-29 14:56:15 PDT
This should probably in the editing for consistency. We should really add a "Hit testing" component.
Comment 4 mitz 2012-07-29 15:56:46 PDT
Fixed in <http://trac.webkit.org/r123988>.
Comment 5 János Badics 2012-07-30 05:23:21 PDT
Unfortunately r123988 made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail on Qt WebKit1. I have created a bug for it on the following link:
https://bugs.webkit.org/show_bug.cgi?id=92636
Comment 6 Csaba Osztrogonác 2012-07-30 06:14:20 PDT
Comment on attachment 155182 [details]
When comparing y coordinates in flipped text, make strict inequalities non-strict and vice versa

View in context: https://bugs.webkit.org/attachment.cgi?id=155182&action=review

> LayoutTests/fast/writing-mode/flipped-blocks-hit-test-line-edges-expected.txt:10
> +PASS: offset at (60,24) was 26.

This new test case fail on Qt and Chromium Linux too.
See the bug report mentioned by the previous comment.
Comment 7 Levi Weintraub 2012-07-30 11:46:31 PDT
Comment on attachment 155182 [details]
When comparing y coordinates in flipped text, make strict inequalities non-strict and vice versa

Clearing flags.