Bug 91339 - [EFL, GTK] css2.1/20110323/vertical-align-boxes-001.htm fails
Summary: [EFL, GTK] css2.1/20110323/vertical-align-boxes-001.htm fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ms2ger (he/him; ⌚ UTC+1/+2)
URL: http://trac.webkit.org/export/122707/...
Keywords:
: 91319 91372 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-07-15 01:33 PDT by Chris Dumez
Modified: 2018-01-11 06:06 PST (History)
10 users (show)

See Also:


Attachments
Rendering of test case by EFL, Chromium Win and GTK (3.72 KB, image/png)
2012-07-16 11:32 PDT, Robert Hogan
no flags Details
Patch (1.41 KB, patch)
2018-01-10 03:47 PST, Ms2ger (he/him; ⌚ UTC+1/+2)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-15 01:33:38 PDT
Added in http://trac.webkit.org/changeset/122663

Gtk and Qt have the same issue: Bug 91319 and Bug 89597.
Comment 1 Chris Dumez 2012-07-15 01:42:02 PDT
Skipping test in Bug 91340, please unskip with proper fix.
Comment 2 Robert Hogan 2012-07-15 03:31:34 PDT
Apologies I didn't notice the failure on EFL - Gtk has the same problem with this test, see bug 91319.
Comment 3 Chris Dumez 2012-07-15 03:35:33 PDT
(In reply to comment #2)
> Apologies I didn't notice the failure on EFL - Gtk has the same problem with this test, see bug 91319.

I know, and same for Qt (Bug 89597). BTW, the bug description already mentions those other bug reports.
Comment 4 Robert Hogan 2012-07-16 11:31:18 PDT
*** Bug 91319 has been marked as a duplicate of this bug. ***
Comment 5 Robert Hogan 2012-07-16 11:31:48 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > Apologies I didn't notice the failure on EFL - Gtk has the same problem with this test, see bug 91319.
> 
> I know, and same for Qt (Bug 89597).

Qt has a different issue that is general to pixel width in reftests. EFL, GTK and Chromium Win all share the same issue with this reftest. I've attached the rendering that all three share.
Comment 6 Robert Hogan 2012-07-16 11:32:43 PDT
Created attachment 152572 [details]
Rendering of test case by EFL, Chromium Win and GTK
Comment 7 Robert Hogan 2012-07-16 11:35:33 PDT
BTW, I believe this is a pre-existing problem exposed by adding this test. The part of the test that renders incorrectly wasn't (afaik) affected by the change. The element that renders correctly has the id 'middle'.

  <div class="test">
    <img id="control" src="support/swatch-blue.png" alt="FAIL"><!--
 --><img id="baseline" src="support/swatch-blue.png" alt="FAIL"><!--
 --><img id="middle" src="support/swatch-blue.png" alt="FAIL"><!--
 --><img id="text-top" src="support/swatch-blue.png" alt="FAIL"><!--
 --><img id="text-bottom" src="support/swatch-blue.png" alt="FAIL"><!--
 --><img id="percent" src="support/swatch-blue.png" alt="FAIL"><!--
 --><img id="length" src="support/swatch-blue.png" alt="FAIL">
  </div>
Comment 8 Robert Hogan 2012-07-16 11:44:12 PDT
*** Bug 91372 has been marked as a duplicate of this bug. ***
Comment 9 Michael Catanzaro 2017-06-07 19:45:57 PDT
Reassigning some EFL bugs that are likely shared with GTK/WPE to the GTK component.
Comment 10 Ms2ger (he/him; ⌚ UTC+1/+2) 2018-01-10 03:47:13 PST
Created attachment 330889 [details]
Patch
Comment 11 WebKit Commit Bot 2018-01-10 03:49:38 PST
Comment on attachment 330889 [details]
Patch

Rejecting attachment 330889 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 330889, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/gtk/TestExpectations
Hunk #1 FAILED at 2608.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/6018288
Comment 12 WebKit Commit Bot 2018-01-10 06:14:27 PST
The commit-queue encountered the following flaky tests while processing attachment 330889 [details]:

http/tests/misc/slow-loading-animated-image.html bug 181479 (author: sabouhallawa@apple.com)
The commit-queue is continuing to process your patch.
Comment 13 WebKit Commit Bot 2018-01-10 06:14:29 PST
The commit-queue encountered the following flaky tests while processing attachment 330889 [details]:

The commit-queue is continuing to process your patch.
Comment 14 WebKit Commit Bot 2018-01-11 06:06:22 PST
Comment on attachment 330889 [details]
Patch

Clearing flags on attachment: 330889

Committed r226774: <https://trac.webkit.org/changeset/226774>
Comment 15 WebKit Commit Bot 2018-01-11 06:06:24 PST
All reviewed patches have been landed.  Closing bug.