Bug 91339 – [EFL, GTK] css2.1/20110323/vertical-align-boxes-001.htm fails

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Chris Dumez]

Added in http://trac.webkit.org/changeset/122663

Gtk and Qt have the same issue: Bug 91319 and Bug 89597.

[Chris Dumez]

Skipping test in Bug 91340, please unskip with proper fix.

[Robert Hogan]

Apologies I didn't notice the failure on EFL - Gtk has the same problem with this test, see bug 91319.

[Chris Dumez]

(In reply to comment #2)
> Apologies I didn't notice the failure on EFL - Gtk has the same problem with this test, see bug 91319.

I know, and same for Qt (Bug 89597). BTW, the bug description already mentions those other bug reports.

[Robert Hogan]

*** Bug 91319 has been marked as a duplicate of this bug. ***

[Robert Hogan]

(In reply to comment #3)
> (In reply to comment #2)
> > Apologies I didn't notice the failure on EFL - Gtk has the same problem with this test, see bug 91319.
> 
> I know, and same for Qt (Bug 89597).

Qt has a different issue that is general to pixel width in reftests. EFL, GTK and Chromium Win all share the same issue with this reftest. I've attached the rendering that all three share.

[Robert Hogan]

Created attachment 152572 [details]
Rendering of test case by EFL, Chromium Win and GTK

[Robert Hogan]

BTW, I believe this is a pre-existing problem exposed by adding this test. The part of the test that renders incorrectly wasn't (afaik) affected by the change. The element that renders correctly has the id 'middle'.

  <div class="test">
    <img id="control" src="support/swatch-blue.png" alt="FAIL"><!--
 --><img id="baseline" src="support/swatch-blue.png" alt="FAIL"><!--
 --><img id="middle" src="support/swatch-blue.png" alt="FAIL"><!--
 --><img id="text-top" src="support/swatch-blue.png" alt="FAIL"><!--
 --><img id="text-bottom" src="support/swatch-blue.png" alt="FAIL"><!--
 --><img id="percent" src="support/swatch-blue.png" alt="FAIL"><!--
 --><img id="length" src="support/swatch-blue.png" alt="FAIL">
  </div>

[Robert Hogan]

*** Bug 91372 has been marked as a duplicate of this bug. ***

[Michael Catanzaro]

Reassigning some EFL bugs that are likely shared with GTK/WPE to the GTK component.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 330889 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 330889 [details]
Patch

Rejecting attachment 330889 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 330889, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/gtk/TestExpectations
Hunk #1 FAILED at 2608.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/6018288

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 330889 [details]:

http/tests/misc/slow-loading-animated-image.html bug 181479 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 330889 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 330889 [details]
Patch

Clearing flags on attachment: 330889

Committed r226774: <https://trac.webkit.org/changeset/226774>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.