Bug 89597 - [Qt] Failing reftests with 1px high line difference on 32 bit
Summary: [Qt] Failing reftests with 1px high line difference on 32 bit
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 62204 87008
  Show dependency treegraph
 
Reported: 2012-06-20 13:08 PDT by Robert Hogan
Modified: 2014-02-03 03:21 PST (History)
4 users (show)

See Also:


Attachments
Diff for abspos-001.html (4.89 KB, image/png)
2012-06-20 13:08 PDT, Robert Hogan
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2012-06-20 13:08:09 PDT
These two fail on Qt only. The diff provided by Qt's ImageDiff is not very informative so I've attached one using Chromium's. There's a 1-pixel high line of difference at the bottom of the test block.

The tests run fine on other ports so there must something Qt-specific at work here. It's safe to skip for now as there is coverage in other ports but it would be nice to understand what the difference at work is here.
Comment 1 Robert Hogan 2012-06-20 13:08:43 PDT
Created attachment 148635 [details]
Diff for abspos-001.html
Comment 2 Csaba Osztrogonác 2012-06-20 13:17:54 PDT
These tests introduced in http://trac.webkit.org/changeset/120844 and
fail only on 32 bit Qt platforms (Qt 4.8, Qt 5.0 WK1 and WK2 too)

I cc-es Zoltán, our 32/64 bit debuger expert. Have you got any idea?

I'm going to skip them until fix to paint the bots green.
Comment 3 Csaba Osztrogonác 2012-06-20 13:32:06 PDT
You were faster than me, thans. ( Skipped by http://trac.webkit.org/changeset/120856 )
Comment 4 Csaba Osztrogonác 2012-06-20 15:13:17 PDT
- fast/block/float/previous-sibling-[abspos|float]-001.html

new failing tests because of this bug:
- fast/block/negative-margin-start-positive-margin-end.html
- fast/block/positive-margin-start-negative-margin-end-align-center.html

http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20-%20Qt5-WebKit1/r120862%20%288930%29/results.html
Comment 5 Csaba Osztrogonác 2012-06-20 15:26:06 PDT
New failing tests skipped by http://trac.webkit.org/changeset/120873
Comment 6 Robert Hogan 2012-07-14 02:51:15 PDT
Committed r122666: <http://trac.webkit.org/changeset/122666>
Comment 7 Robert Hogan 2012-07-14 02:53:02 PDT
Didn't mean for that to happen..
Comment 8 Csaba Osztrogonác 2012-07-23 08:10:47 PDT
- one more failing test because of this bug: svg/as-image/svg-intrinsic-size-rectangular-vertical.html
- diff: http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20-%20Qt5-WebKit1/r123337%20%2810077%29/svg/as-image/svg-intrinsic-size-rectangular-vertical-diffs.html
- skipped by https://trac.webkit.org/changeset/123338
Comment 9 Jocelyn Turcotte 2014-02-03 03:21:23 PST
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.