Steps To Reproduce: 1. Open Safari or S60 Web Browser 2. Load the test file 3. Click the link "Prompt" 4. Edit text in the prompt dialog 5. Select OK for prompt dialog. Expected Result: Prompt dialog closes and result page is loaded with the edited text Actual Result: Prompt dialog closes and a blank result page opened. Test source: <html> <head> <script type="text/javascript"> function message(){ var name = prompt("Please enter your name","John Wayne") if (name != null && name != "") { document.write("Hello " + name) } } </script> </head> <body> <p> Select the link "Prompt" and verify that the prompt dialog is displayed correctly. </p> <a href="javascript: message()">Prompt</a> <br/> </body> </html>
Created attachment 8372 [details] prompt dialog test case This test page is same as the given test source in the description.
(In reply to comment #1) > Created an attachment (id=8372) [edit] > prompt dialog test case > This test page is same as the given test source in the description. The browser expects the close html tag, after the document writes are complete. The behaviour is same on both safari and S60 Web Browser. The follwoing function works ok. But can we expect the content author to write this kind of javascript function? function message(){ var name = prompt("Please enter your name","John Wayne") alert(name); if (name != null && name != "") { document.write("Hello " + name); document.write("</body></html>"); } }
The text does get displayed when any HTML tag is written, though - try changing the name to "John Wayne</p>". Or to "John<p>Wayne".
TSW Error ID: EXTH-6HL4ZD
*** Bug 9587 has been marked as a duplicate of this bug. ***
(In reply to comment #5) > *** Bug 9587 has been marked as a duplicate of this bug. *** Hmm...how do we want to handle this? My inclination is to change the Hardware, OS and Version settings to match "HEAD" rather than the S60 branch. Should we just keep these bugs separate instead?
(In reply to comment #6) > Hmm...how do we want to handle this? My inclination is to change the Hardware, > OS and Version settings to match "HEAD" rather than the S60 branch. Indeed - I've been told before that this is how bugs still present in TOT are supposed to be handled. Changing to All/All/420+.
I definitly agree on this, it's up to nokia to backport a patch :) .
Created attachment 12004 [details] automated test
*** Bug 14709 has been marked as a duplicate of this bug. ***
Bug 14709 has some in-depth discussion of this issue.
Created attachment 16888 [details] a slightly more evil test
*** Bug 7885 has been marked as a duplicate of this bug. ***
*** Bug 16762 has been marked as a duplicate of this bug. ***
Created attachment 19076 [details] This patch fixes the test cases. Nobody ever recorded which Acid3 test this affects in the bug. My score on Acid3 does not change with this patch, so either the patch isn't good enough or the test has changed to make this no longer be an Acid3 issue.
Looks like this is no longer related to Acid3.
Comment on attachment 19076 [details] This patch fixes the test cases. I will land the evil test case from the bug.
(In reply to comment #15) > Created an attachment (id=19076) [edit] > This patch fixes the test cases. > > Nobody ever recorded which Acid3 test this affects in the bug. My score on > Acid3 does not change with this patch, so either the patch isn't good enough or > the test has changed to make this no longer be an Acid3 issue. > Dave, look into this bug 16762. The bug have description about relation between Acid3 test and this bug.
Comment on attachment 19076 [details] This patch fixes the test cases. Actually need to think about this some more.
I believe this is the bug causing these Hixie tests to fail: http://hixie.ch/tests/adhoc/dom/level0/write/007.html http://hixie.ch/tests/adhoc/dom/level0/write/008.html
*** Bug 20563 has been marked as a duplicate of this bug. ***
*** Bug 20970 has been marked as a duplicate of this bug. ***
*** Bug 22234 has been marked as a duplicate of this bug. ***
*** Bug 13043 has been marked as a duplicate of this bug. ***
*** Bug 26432 has been marked as a duplicate of this bug. ***
Created attachment 64401 [details] Patch
Comment on attachment 64401 [details] Patch WebCore/ChangeLog:9 + reached the end of the input stream, but that's now how the spec now how. You mean "not" how. Yay test driven development!
*** Bug 14599 has been marked as a duplicate of this bug. ***
Created attachment 64402 [details] Patch for landing
Comment on attachment 64402 [details] Patch for landing Rejecting patch 64402 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Last 500 characters of output: ocument-write-evil-expected.txt patching file LayoutTests/fast/tokenizer/flush-characters-in-document-write-evil.html patching file LayoutTests/fast/tokenizer/flush-characters-in-document-write-expected.txt patching file LayoutTests/fast/tokenizer/flush-characters-in-document-write.html patching file WebCore/ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/ChangeLog.rej patching file WebCore/html/HTMLTokenizer.cpp patching file WebCore/html/HTMLTokenizer.h Full output: http://queues.webkit.org/results/3775148
Created attachment 64409 [details] Patch for landing
Comment on attachment 64409 [details] Patch for landing Rejecting patch 64409 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20839 test cases. http/tests/appcache/credential-url.html -> crashed Exiting early after 1 failures. 19873 tests run. 747.73s total testing time 19872 test cases (99%) succeeded 1 test case (<1%) crashed 281 test cases (1%) had stderr output Full output: http://queues.webkit.org/results/3768150
Comment on attachment 64409 [details] Patch for landing Looks like a flake.
Comment on attachment 64409 [details] Patch for landing Rejecting patch 64409 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20840 test cases. http/tests/appcache/credential-url.html -> crashed Exiting early after 1 failures. 19874 tests run. 738.32s total testing time 19873 test cases (99%) succeeded 1 test case (<1%) crashed 276 test cases (1%) had stderr output Full output: http://queues.webkit.org/results/3747160
This patch caused an existing test to expose an existing crasher (Bug 44024), which we'll want to fix before landing this patch. ;)
Comment on attachment 64409 [details] Patch for landing Okiedokes. Let's give this another try.
Comment on attachment 64409 [details] Patch for landing Clearing flags on attachment: 64409 Committed r65382: <http://trac.webkit.org/changeset/65382>
All reviewed patches have been landed. Closing bug.
re-purposing InTSW keyword for use by QtWebkit team