Expose layoutTestController as testRunner
Created attachment 145512 [details] Patch
Comment on attachment 145512 [details] Patch Looks good for DumpRenderTree and TestShell, but to handle WebKitTestRunner, we also need a change to LayoutTestController::makeWindowObject in Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp. Since this adds a test, we’ll start seeing failures if you don’t add that, so review-.
(In reply to comment #2) > (From update of attachment 145512 [details]) > Looks good for DumpRenderTree and TestShell, but to handle WebKitTestRunner, we also need a change to LayoutTestController::makeWindowObject in Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp. Since this adds a test, we’ll start seeing failures if you don’t add that, so review-. Oops, I had that change in my mind and totally forgot about it. Uploading a new patch now.
Created attachment 145529 [details] Added the forgotten WebKitTestRunner change
Ping reviewers.
Could someone review the patch?
Thanks! I'll land this, and start converting tests.
Comment on attachment 145529 [details] Added the forgotten WebKitTestRunner change Clearing flags on attachment: 145529 Committed r119946: <http://trac.webkit.org/changeset/119946>
All reviewed patches have been landed. Closing bug.
Why doesn't this property get dumped and so show up in “all the properties of the window object” tests?
(In reply to comment #10) > Why doesn't this property get dumped and so show up in “all the properties of the window object” tests? Which test are you talking about? I thought we got rid of those dump-all-properties tests?