Bug 88955 - Editing tests should use testRunner instead of layoutTestController
Summary: Editing tests should use testRunner instead of layoutTestController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 88210
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-12 21:41 PDT by Ryosuke Niwa
Modified: 2012-06-13 02:52 PDT (History)
5 users (show)

See Also:

Attachments
Patch (885.90 KB, patch)
2012-06-12 21:59 PDT, Ryosuke Niwa 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-06-12 21:41:57 PDT 
Editing tests should use testRunner instead of layoutTestController.
Comment 1 Ryosuke Niwa 2012-06-12 21:59:13 PDT 
Created attachment 147224 [details]
Patch
Comment 2 Ryosuke Niwa 2012-06-12 22:02:23 PDT 
Comment on attachment 147224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147224&action=review

> LayoutTests/ChangeLog:13
> +        * platform/chromium-win/editing/selection/paragraph-granularity-expected.txt:
> +        * platform/chromium-win/editing/selection/triple-click-in-pre-expected.txt:
> +        * platform/chromium-win/editing/selection/word-granularity-expected.txt:

These 3 tests need to be rebaselined manually after the patch is landed.
Comment 3 Darin Adler 2012-06-12 23:01:46 PDT 
Comment on attachment 147224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147224&action=review

rs=me

Not sure why the pasteboard data is showing up in the diff. Doesn't seem right to change that.

> LayoutTests/editing/deleting/2610675-3.html:18
> +    window.testRunner.dumpAsText();

Some day I think I’ll go take out all the "window." prefixes on lines like this one.

> LayoutTests/editing/deleting/2610675-3.html:20
>  window.getSelection().setPosition(blockquote, 0);

And lines like this one.

> LayoutTests/editing/selection/paragraph-granularity.html:37
> +<p style="color:green">This test does not run interactively.  It uses the testRunners eventSender to do mouse clicks.  To run it manually, double click on the blue 'g', then drag down to the red 'g'.  As you drag, watch the selection that is created, it should always start and end on paragraph boundaries.</p>

Not great grammar here. Should be "the testRunner's eventSender" or, if it was me, "the test runner's event sender".
Comment 4 Ryosuke Niwa 2012-06-13 01:52:06 PDT 
Committed r120173: <http://trac.webkit.org/changeset/120173>
Comment 5 Ryosuke Niwa 2012-06-13 02:23:59 PDT 
Somehow my commit removed two files :( Reverting those.
Comment 6 Ryosuke Niwa 2012-06-13 02:52:51 PDT 
Reverted the removals in http://trac.webkit.org/changeset/120176.