Bug 88955 – Editing tests should use testRunner instead of layoutTestController

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

Editing tests should use testRunner instead of layoutTestController.

[Ryosuke Niwa]

Created attachment 147224 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 147224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147224&action=review

> LayoutTests/ChangeLog:13
> +        * platform/chromium-win/editing/selection/paragraph-granularity-expected.txt:
> +        * platform/chromium-win/editing/selection/triple-click-in-pre-expected.txt:
> +        * platform/chromium-win/editing/selection/word-granularity-expected.txt:

These 3 tests need to be rebaselined manually after the patch is landed.

[Darin Adler]

Comment on attachment 147224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147224&action=review

rs=me

Not sure why the pasteboard data is showing up in the diff. Doesn't seem right to change that.

> LayoutTests/editing/deleting/2610675-3.html:18
> +    window.testRunner.dumpAsText();

Some day I think I’ll go take out all the "window." prefixes on lines like this one.

> LayoutTests/editing/deleting/2610675-3.html:20
>  window.getSelection().setPosition(blockquote, 0);

And lines like this one.

> LayoutTests/editing/selection/paragraph-granularity.html:37
> +<p style="color:green">This test does not run interactively.  It uses the testRunners eventSender to do mouse clicks.  To run it manually, double click on the blue 'g', then drag down to the red 'g'.  As you drag, watch the selection that is created, it should always start and end on paragraph boundaries.</p>

Not great grammar here. Should be "the testRunner's eventSender" or, if it was me, "the test runner's event sender".

[Ryosuke Niwa]

Committed r120173: <http://trac.webkit.org/changeset/120173>

[Ryosuke Niwa]

Somehow my commit removed two files :( Reverting those.

[Ryosuke Niwa]

Reverted the removals in http://trac.webkit.org/changeset/120176.