Bug 88761 - Use testRunner instead of layoutTestController in battery status and canvas tests
Summary: Use testRunner instead of layoutTestController in battery status and canvas t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 88210
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-11 00:22 PDT by Ryosuke Niwa
Modified: 2012-06-14 23:23 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.59 KB, patch)
2012-06-11 00:28 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch (4.08 KB, patch)
2012-06-11 00:30 PDT, Ryosuke Niwa 		tony: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-06-11 00:22:53 PDT 
Use testRunner instead of layoutTestController in battery status and canvas tests
Comment 1 Ryosuke Niwa 2012-06-11 00:28:30 PDT 
Created attachment 146799 [details]
Patch
Comment 2 Ryosuke Niwa 2012-06-11 00:30:37 PDT 
Created attachment 146800 [details]
Patch
Comment 3 Ryosuke Niwa 2012-06-11 00:34:10 PDT 
Ran:
find LayoutTests/batterystatus/ LayoutTests/platform/*/batterystatus/ -type f -not -iwholename "*.svn*" -not -name "*.png" -not -name "*.ttf" -not -name "*.gif" | xargs sed -i -e "s/layoutTestController/testRunner/g"
find LayoutTests/canvas/ LayoutTests/platform/*/canvas/ -type f -not -iwholename "*.svn*" -not -name "*.png" -not -name "*.ttf" -not -name "*.gif" | xargs sed -i -e "s/layoutTestController/testRunner/g"
Comment 4 Tony Chang 2012-06-11 10:13:05 PDT 
Comment on attachment 146800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146800&action=review

> LayoutTests/canvas/philip/tests/2d.text-custom-font-load-crash.html:30
>  }), 500);

This timeout is unfortunate, but unrelated to your patch.
Comment 5 Ryosuke Niwa 2012-06-14 23:23:27 PDT 
Committed r120407: <http://trac.webkit.org/changeset/120407>