WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
83811
Stop exposing RenderLayer knowledge to the code outside rendering/
https://bugs.webkit.org/show_bug.cgi?id=83811
Summary
Stop exposing RenderLayer knowledge to the code outside rendering/
Julien Chaffraix
Reported
2012-04-12 13:17:53 PDT
Currently RenderLayer's getter is public (RenderBoxModelObject::layer()) which makes it convenient for people to start poking the layer. However this is hurting us as objects outside rendering have some very deep knowledge of how rendering is supposed to work. This breaks the rendering abstraction and makes it harder to refactor RenderLayer in many ways. I haven't thought deeply on that but RenderObject::hasLayer() should likely be made protected too as this is an implementation detail.
Attachments
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2013-02-27 14:35:02 PST
Sounds like a great idea to me.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug