Bug 83811 - Stop exposing RenderLayer knowledge to the code outside rendering/
Summary: Stop exposing RenderLayer knowledge to the code outside rendering/
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 83728 83816 84090 84607
Blocks:
  Show dependency tree / graph
 
Reported: 2012-04-12 13:17 PDT by Julien Chaffraix
Modified: 2013-02-27 20:42 PST (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-04-12 13:17:53 PDT 
Currently RenderLayer's getter is public (RenderBoxModelObject::layer()) which makes it convenient for people to start poking the layer. However this is hurting us as objects outside rendering have some very deep knowledge of how rendering is supposed to work. This breaks the rendering abstraction and makes it harder to refactor RenderLayer in many ways.

I haven't thought deeply on that but RenderObject::hasLayer() should likely be made protected too as this is an implementation detail.
Comment 1 Eric Seidel (no email) 2013-02-27 14:35:02 PST 
Sounds like a great idea to me.