A lot of the code outside rendering/ is talking directly to a RenderLayer where they shouldn't have such a deep knowledge of the rendering objects. This unfortunately propagates some rendering knowledge and assumptions outside the scope of rendering. It also ties our code to relying on RenderLayer for certain operations that reduces the abstraction.
Created attachment 136784 [details] Proposed refactoring 1: Add 2 helpers functions, remove a third of the use, happily welcome comments on the naming.
Comment on attachment 136784 [details] Proposed refactoring 1: Add 2 helpers functions, remove a third of the use, happily welcome comments on the naming. Attachment 136784 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12390125
Comment on attachment 136784 [details] Proposed refactoring 1: Add 2 helpers functions, remove a third of the use, happily welcome comments on the naming. Attachment 136784 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12389211
Created attachment 136799 [details] Fixed Gtk / Qt by adding RenderObject.h include. One more round for the EWS.
Comment on attachment 136799 [details] Fixed Gtk / Qt by adding RenderObject.h include. One more round for the EWS. Clearing flags on attachment: 136799 Committed r113990: <http://trac.webkit.org/changeset/113990>
All reviewed patches have been landed. Closing bug.