Bug 84607 - Cut dependency on RenderLayer::scrollRectToVisible outside rendering
: Cut dependency on RenderLayer::scrollRectToVisible outside rendering
Status: RESOLVED FIXED
: WebKit
Layout and Rendering
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
: 83811
  Show dependency treegraph
 
Reported: 2012-04-23 09:59 PST by
Modified: 2012-04-23 16:50 PST (History)


Attachments
Proposed fix 1: Add RenderObject::scrollRectToVisible. (14.19 KB, patch)
2012-04-23 10:23 PST, Julien Chaffraix
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-23 09:59:04 PST
Currently the logic assumes that there is a RenderLayer to handle a scrollRectToVisible action as it needs to query the enclosing RenderLayer. This exposes RenderLayer to the non-rendering code, thus exposing needlessly a rendering-only concept.

Patch forthcoming.
------- Comment #1 From 2012-04-23 10:23:22 PST -------
Created an attachment (id=138376) [details]
Proposed fix 1: Add RenderObject::scrollRectToVisible.
------- Comment #2 From 2012-04-23 16:49:55 PST -------
(From update of attachment 138376 [details])
Clearing flags on attachment: 138376

Committed r114962: <http://trac.webkit.org/changeset/114962>
------- Comment #3 From 2012-04-23 16:50:07 PST -------
All reviewed patches have been landed.  Closing bug.