Bug 84607 - Cut dependency on RenderLayer::scrollRectToVisible outside rendering
Summary: Cut dependency on RenderLayer::scrollRectToVisible outside rendering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks: 83811
  Show dependency tree / graph
 
Reported: 2012-04-23 09:59 PDT by Julien Chaffraix
Modified: 2012-04-23 16:50 PDT (History)
3 users (show)

See Also:

Attachments
Proposed fix 1: Add RenderObject::scrollRectToVisible. (14.19 KB, patch)
2012-04-23 10:23 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-04-23 09:59:04 PDT 
Currently the logic assumes that there is a RenderLayer to handle a scrollRectToVisible action as it needs to query the enclosing RenderLayer. This exposes RenderLayer to the non-rendering code, thus exposing needlessly a rendering-only concept.

Patch forthcoming.
Comment 1 Julien Chaffraix 2012-04-23 10:23:22 PDT 
Created attachment 138376 [details]
Proposed fix 1: Add RenderObject::scrollRectToVisible.
Comment 2 WebKit Review Bot 2012-04-23 16:49:55 PDT 
Comment on attachment 138376 [details]
Proposed fix 1: Add RenderObject::scrollRectToVisible.

Clearing flags on attachment: 138376

Committed r114962: <http://trac.webkit.org/changeset/114962>
Comment 3 WebKit Review Bot 2012-04-23 16:50:07 PDT 
All reviewed patches have been landed.  Closing bug.