Bug 84090 - Refactor windowClipRectForLayer to remove the explicit RenderLayer dependency
Summary: Refactor windowClipRectForLayer to remove the explicit RenderLayer dependency
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks: 83811
  Show dependency tree / graph
 
Reported: 2012-04-16 15:46 PDT by Julien Chaffraix
Modified: 2012-05-07 16:33 PDT (History)
7 users (show)

See Also:

Attachments
Proposed renaming / API change 1. (12.10 KB, patch)
2012-04-16 16:02 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Proposed renaming / API change 2: fixed platforms compiling PluginView. (15.93 KB, patch)
2012-04-16 19:21 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Proposed change 3: Fixed EmbeddedWidget for win. (18.21 KB, patch)
2012-04-17 09:41 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-04-16 15:46:22 PDT 
windowClipRectForLayer is not a general purpose function as its name would imply. It's actually used only to get an HTMLFrameOwner clip rect. For clarity it could be renamed and also we could remove the unneeded dependency on RenderLayer.
Comment 1 Julien Chaffraix 2012-04-16 16:02:45 PDT 
Created attachment 137423 [details]
Proposed renaming / API change 1.
Comment 2 Build Bot 2012-04-16 16:27:38 PDT 
Comment on attachment 137423 [details]
Proposed renaming / API change 1.

Attachment 137423 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12416323
Comment 3 Early Warning System Bot 2012-04-16 16:41:22 PDT 
Comment on attachment 137423 [details]
Proposed renaming / API change 1.

Attachment 137423 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12415442
Comment 4 Philippe Normand 2012-04-16 17:00:43 PDT 
Comment on attachment 137423 [details]
Proposed renaming / API change 1.

Attachment 137423 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12417290
Comment 5 Julien Chaffraix 2012-04-16 19:21:46 PDT 
Created attachment 137458 [details]
Proposed renaming / API change 2: fixed platforms compiling PluginView.
Comment 6 Build Bot 2012-04-16 19:45:21 PDT 
Comment on attachment 137458 [details]
Proposed renaming / API change 2: fixed platforms compiling PluginView.

Attachment 137458 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12423011
Comment 7 Julien Chaffraix 2012-04-17 09:41:02 PDT 
Created attachment 137549 [details]
Proposed change 3: Fixed EmbeddedWidget for win.
Comment 8 Dave Hyatt 2012-05-07 14:11:02 PDT 
Comment on attachment 137549 [details]
Proposed change 3: Fixed EmbeddedWidget for win.

Looks good. r=me
Comment 9 WebKit Review Bot 2012-05-07 16:33:12 PDT 
Comment on attachment 137549 [details]
Proposed change 3: Fixed EmbeddedWidget for win.

Clearing flags on attachment: 137549

Committed r116371: <http://trac.webkit.org/changeset/116371>
Comment 10 WebKit Review Bot 2012-05-07 16:33:17 PDT 
All reviewed patches have been landed.  Closing bug.