Bug 76257 – [Win][JSC] Eliminate JavaScriptCore.def

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Platform

[Hajime Morrita]

This is a twin of Bug 72854.
We now have export macros in the tree.
it should be possible to get rid of the .def file.

[Adam Roben (:aroben)]

I wonder if this will change the mangling of exported symbols and thus break nightly builds?

[Hajime Morrita]

Hi Adam, thanks for watching this ;-)

> I wonder if this will change the mangling of exported symbols and thus break nightly builds?
I tried it locally and found we need some changes to make it buildable.
The trickiest part is that some WTF string related files are built into WebCore.
We need some workaround for that. I'm investigating better way.

Other fixes will be more trivial - just adding some preprocessor #define-s to compiler options.

[Adam Roben (:aroben)]

(In reply to comment #2)
> Hi Adam, thanks for watching this ;-)
> 
> > I wonder if this will change the mangling of exported symbols and thus break nightly builds?
> I tried it locally and found we need some changes to make it buildable.

OK. What I'm wondering though is: once this configuration is "buildable", will nightly builds still work? I.e., will the JavaScriptCore.dll that gets produced using the new process be usable by current versions of Safari?

[Hajime Morrita]

(In reply to comment #3)
> OK. What I'm wondering though is: once this configuration is "buildable", will nightly builds still work? I.e., will the JavaScriptCore.dll that gets produced using the new process be usable by current versions of Safari?
Good point. I need to check it locally as a part of this change.
Assuming there is no windows specific JSC API, it should work.

[Patrick R. Gansterer]

Created attachment 155116 [details]
Patch to check EWS

[Patrick R. Gansterer]

Created attachment 155117 [details]
Patch to check EWS

[WebKit Review Bot]

Attachment 155117 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/WTF/wtf/text/AtomicString.h:82:  The parameter name "s" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Patrick R. Gansterer]

Created attachment 155122 [details]
Patch to check EWS

[WebKit Review Bot]

Attachment 155122 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/WTF/wtf/text/AtomicString.h:82:  The parameter name "s" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 155122 [details]
Patch to check EWS

Attachment 155122 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13370925

[Patrick R. Gansterer]

Created attachment 155126 [details]
Patch to check EWS

[WebKit Review Bot]

Attachment 155126 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/WTF/wtf/text/AtomicString.h:82:  The parameter name "s" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Patrick R. Gansterer]

Created attachment 155129 [details]
Patch to check EWS

[WebKit Review Bot]

Attachment 155129 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/WTF/wtf/text/AtomicString.h:82:  The parameter name "s" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 155129 [details]
Patch to check EWS

Attachment 155129 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13374885

[Patrick R. Gansterer]

Created attachment 155130 [details]
Patch to check EWS

[Hajime Morrita]

This is great!!

My picky feeling says WTF_EXPORT_PRIVATE_STRINGSTUFF is too long and strnage.
Something like WTF_EXPORT_STRING_API will be better.
But that's tiny point. This is a big deal. Thanks for taking this!

[Patrick R. Gansterer]

*** This bug has been marked as a duplicate of bug 117050 ***