Bug 92851 - Export StringImpl::sizeInBytes() with WTF_EXPORT_STRING_API
Summary: Export StringImpl::sizeInBytes() with WTF_EXPORT_STRING_API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 76257
  Show dependency tree / graph
 
Reported: 2012-08-01 01:08 PDT by Patrick R. Gansterer
Modified: 2012-08-01 05:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.20 KB, patch)
2012-08-01 01:12 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-08-01 01:08:17 PDT 
Export StringImpl::sizeInBytes() with WTF_EXPORT_STRING_API
Comment 1 Patrick R. Gansterer 2012-08-01 01:12:28 PDT 
Created attachment 155744 [details]
Patch
Comment 2 Hajime Morrita 2012-08-01 02:22:47 PDT 
Comment on attachment 155744 [details]
Patch

Looks good.

By the way, Could you address https://bugs.webkit.org/show_bug.cgi?id=92624#c8 in separate
patch in some timing? I'm sorry that my suggestion there was wrong...
Comment 3 Patrick R. Gansterer 2012-08-01 02:26:26 PDT 
(In reply to comment #2)
> (From update of attachment 155744 [details])
> Looks good.
> 
> By the way, Could you address https://bugs.webkit.org/show_bug.cgi?id=92624#c8 in separate
> patch in some timing? I'm sorry that my suggestion there was wrong...

I'm waiting for some response from Darin currently. My plan was to create a patch with a "_PRIVATE_" in the macro name at the weekend, if there is no response until then and CC him. -> It's on my list. :-)
Comment 4 Hajime Morrita 2012-08-01 02:36:36 PDT 
> I'm waiting for some response from Darin currently. My plan was to create a patch with a "_PRIVATE_" in the macro name at the weekend, if there is no response until then and CC him. -> It's on my list. :-)
Sounds good :-)
Comment 5 WebKit Review Bot 2012-08-01 05:24:10 PDT 
Comment on attachment 155744 [details]
Patch

Clearing flags on attachment: 155744

Committed r124328: <http://trac.webkit.org/changeset/124328>
Comment 6 WebKit Review Bot 2012-08-01 05:24:13 PDT 
All reviewed patches have been landed.  Closing bug.