Add special export macro for string related functions
Created attachment 155241 [details] Patch
Attachment 155241 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Ex..." exit_code: 1 Source/WTF/wtf/text/AtomicString.h:82: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 155241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155241&action=review r- due to style error. The code direction looks fine to me. > Source/WTF/wtf/ExportMacros.h:144 > +#if PLATFORM(WIN) I expect this conditional to be tuned in coming revisions, right? If so, it's OK for now.
Created attachment 155244 [details] Patch (In reply to comment #3) > > Source/WTF/wtf/ExportMacros.h:144 > > +#if PLATFORM(WIN) > > I expect this conditional to be tuned in coming revisions, right? Yes, in the commit, where i change the build system.
Comment on attachment 155244 [details] Patch Looks good. Please wait until bots become green.
Comment on attachment 155244 [details] Patch Clearing flags on attachment: 155244 Committed r124069: <http://trac.webkit.org/changeset/124069>
All reviewed patches have been landed. Closing bug.
Comment on attachment 155244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155244&action=review > Source/WTF/wtf/ExportMacros.h:148 > +#if PLATFORM(WIN) > +#define WTF_EXPORT_STRING_API > +#else > +#define WTF_EXPORT_STRING_API WTF_EXPORT_PRIVATE > +#endif The use of the term API here is misleading. These are private entry points for use only within the WebKit project, right? So they are not API.
(In reply to comment #8) > (From update of attachment 155244 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155244&action=review > > > Source/WTF/wtf/ExportMacros.h:148 > > +#if PLATFORM(WIN) > > +#define WTF_EXPORT_STRING_API > > +#else > > +#define WTF_EXPORT_STRING_API WTF_EXPORT_PRIVATE > > +#endif > > The use of the term API here is misleading. These are private entry points for use only within the WebKit project, right? So they are not API. True. Maybe WTF_EXPORT_PRIVATE_STRING_API?