Bug 92842 - [WIN] Add missing WTF export macros to functions
Summary: [WIN] Add missing WTF export macros to functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 76257
  Show dependency tree / graph
 
Reported: 2012-07-31 23:13 PDT by Patrick R. Gansterer
Modified: 2012-08-01 03:08 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.58 KB, patch)
2012-07-31 23:18 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (4.61 KB, patch)
2012-08-01 02:00 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-07-31 23:13:32 PDT 
[WIN] Add missing WTF export macros to functions
Comment 1 Patrick R. Gansterer 2012-07-31 23:18:28 PDT 
Created attachment 155726 [details]
Patch
Comment 2 Hajime Morrita 2012-07-31 23:27:24 PDT 
Comment on attachment 155726 [details]
Patch

The change looks innocent. Please update before landing.
Comment 3 Patrick R. Gansterer 2012-08-01 02:00:10 PDT 
Created attachment 155758 [details]
Patch
Comment 4 WebKit Review Bot 2012-08-01 02:03:06 PDT 
Attachment 155758 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Th..." exit_code: 1
Source/WTF/wtf/unicode/UTF8.h:79:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Review Bot 2012-08-01 02:16:50 PDT 
Comment on attachment 155726 [details]
Patch

Cleared Hajime Morita's review+ from obsolete attachment 155726 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 6 WebKit Review Bot 2012-08-01 03:08:12 PDT 
Comment on attachment 155758 [details]
Patch

Clearing flags on attachment: 155758

Committed r124320: <http://trac.webkit.org/changeset/124320>
Comment 7 WebKit Review Bot 2012-08-01 03:08:15 PDT 
All reviewed patches have been landed.  Closing bug.