See https://bugs.webkit.org/show_bug.cgi?id=68237#c2 .
Created attachment 108860 [details] Install the flag, which indicates whether or not the optimization script was executed, on the global object.
Comment on attachment 108860 [details] Install the flag, which indicates whether or not the optimization script was executed, on the global object. Looks good. Thanks for cleaning this up. r=me
Comment on attachment 108860 [details] Install the flag, which indicates whether or not the optimization script was executed, on the global object. Clearing flags on attachment: 108860 Committed r96135: <http://trac.webkit.org/changeset/96135>
All reviewed patches have been landed. Closing bug.
Comment on attachment 108860 [details] Install the flag, which indicates whether or not the optimization script was executed, on the global object. View in context: https://bugs.webkit.org/attachment.cgi?id=108860&action=review > Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:36 > -const char fastSetFlagName[] = "webgl::FastSetFlag"; > +// The random suffix helps to avoid name collision. > +const char fastSetFlagName[] = "TypedArray::FastSet::8NkZVq"; There's no reason to use goofy names like this. The http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h class helps us avoid naming collisions.
Thanks, Adam! I file a bug https://bugs.webkit.org/show_bug.cgi?id=104099 and will upload a fix.