Bug 68890 - [v8] Code calling the typed array optimization script is fragile, depends on typed array hierarchy.
Summary: [v8] Code calling the typed array optimization script is fragile, depends on ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ulan Degenbaev
URL:
Keywords:
Depends on: 68237
Blocks: 75532 76040 104099
  Show dependency treegraph
 
Reported: 2011-09-27 05:04 PDT by Ulan Degenbaev
Modified: 2012-12-05 01:23 PST (History)
3 users (show)

See Also:


Attachments
Install the flag, which indicates whether or not the optimization script was executed, on the global object. (2.68 KB, patch)
2011-09-27 09:52 PDT, Ulan Degenbaev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulan Degenbaev 2011-09-27 05:04:14 PDT
See https://bugs.webkit.org/show_bug.cgi?id=68237#c2 .
Comment 1 Ulan Degenbaev 2011-09-27 09:52:30 PDT
Created attachment 108860 [details]
Install the flag, which indicates whether or not the optimization script was executed, on the global object.
Comment 2 Kenneth Russell 2011-09-27 10:47:32 PDT
Comment on attachment 108860 [details]
Install the flag, which indicates whether or not the optimization script was executed, on the global object.

Looks good. Thanks for cleaning this up. r=me
Comment 3 WebKit Review Bot 2011-09-27 11:18:06 PDT
Comment on attachment 108860 [details]
Install the flag, which indicates whether or not the optimization script was executed, on the global object.

Clearing flags on attachment: 108860

Committed r96135: <http://trac.webkit.org/changeset/96135>
Comment 4 WebKit Review Bot 2011-09-27 11:18:10 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Adam Barth 2012-12-04 21:06:42 PST
Comment on attachment 108860 [details]
Install the flag, which indicates whether or not the optimization script was executed, on the global object.

View in context: https://bugs.webkit.org/attachment.cgi?id=108860&action=review

> Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:36
> -const char fastSetFlagName[] = "webgl::FastSetFlag";
> +// The random suffix helps to avoid name collision.
> +const char fastSetFlagName[] = "TypedArray::FastSet::8NkZVq";

There's no reason to use goofy names like this.  The http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h class helps us avoid naming collisions.
Comment 6 Ulan Degenbaev 2012-12-05 01:23:23 PST
Thanks, Adam! I file a bug https://bugs.webkit.org/show_bug.cgi?id=104099 and will upload a fix.