Bug 76040 – [v8] Int16Array.set(array, offset) fails on first execution

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Ulan Degenbaev]

The set() method of typed arrays ignores the offset argument on the first execution. For details see http://code.google.com/p/chromium/issues/detail?id=109785

[Ulan Degenbaev]

Created attachment 121997 [details]
Pass the offset argument to copyElements

Ken, could you please take a look?

The problem was that I missed the offset argument when calling copyElements. 
It passed the unit-tests because the fast set() method happened to be installed when calling set() with offset.

I added a separate test which calls the set with a valid offset at the beginning. There is not need for testing invalid offset because in such case copyElements is not called at all.

[Kenneth Russell]

Comment on attachment 121997 [details]
Pass the offset argument to copyElements

View in context: https://bugs.webkit.org/attachment.cgi?id=121997&action=review

Fix looks good. Is it possible to also incorporate tests for this into the array-unit-tests.html test? If not (because it only happens the first time set() is called for each view type) then the separate test case is fine. Marking cq- until this question is answered.

> ChangeLog:6
> +        Reviewed by Kenneth Russell.

Leave the "Reviewed by NOBODY" line alone when uploading patches. The commit process patches it up automatically.

[Ulan Degenbaev]

>  Is it possible to also incorporate tests for this into the array-unit-tests.html test? If not (because it only happens the first time set() is called for each view type) then the separate test case is fine. 

Yes, it happens only once on the first call, so I would prefer a separate test, otherwise this test could be accidentally disabled when changing array-unit-tests in future.

> Leave the "Reviewed by NOBODY" line alone when uploading patches. The commit process patches it up automatically.
I see, thanks.

[Kenneth Russell]

Comment on attachment 121997 [details]
Pass the offset argument to copyElements

OK. Code and tests look good. Setting cq+.

[WebKit Review Bot]

Comment on attachment 121997 [details]
Pass the offset argument to copyElements

Clearing flags on attachment: 121997

Committed r104736: <http://trac.webkit.org/changeset/104736>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.