Bug 104099 – [v8] Fix hidden property name of V8ArrayBufferView flag.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Ulan Degenbaev]

Instead of appending random characters to the name like "TypedArray::FastSet::8NkZVq" we should use  http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h to avoid name collisions.

[Ulan Degenbaev]

Created attachment 177719 [details]
Patch

[Kenneth Russell]

Comment on attachment 177719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177719&action=review

Thanks for the patch and sorry for not knowing about V8HiddenPropertyName. Could you please rebase the patch?

> Source/WebCore/bindings/v8/V8HiddenPropertyName.h:53
> +    V(typedArrayFastSetFlag)

Should this be named something like typedArrayHiddenCopyMethod?

[Adam Barth]

*** Bug 104192 has been marked as a duplicate of this bug. ***

[Ulan Degenbaev]

Created attachment 177965 [details]
Patch

[Kentaro Hara]

Comment on attachment 177965 [details]
Patch

LGTM. Thanks for the fix!

[Ulan Degenbaev]

> Should this be named something like typedArrayHiddenCopyMethod?
Yes, thanks for catching this. I did the change based on the old patch.

> Could you please rebase the patch?
Done.

[Ulan Degenbaev]

This was fast review. Thank you, Kentaro!

[WebKit Review Bot]

Comment on attachment 177965 [details]
Patch

Rejecting attachment 177965 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ing file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/bindings/v8/V8HiddenPropertyName.h
Hunk #1 FAILED at 49.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/v8/V8HiddenPropertyName.h.rej
patching file Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15159623

[Kentaro Hara]

Looks like you need to rebase it once again.

[Ulan Degenbaev]

Created attachment 177967 [details]
Patch

[WebKit Review Bot]

Comment on attachment 177967 [details]
Patch

Clearing flags on attachment: 177967

Committed r136824: <http://trac.webkit.org/changeset/136824>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.