Bug 67409 - Consider Conditional attribute in CodeGenerator for methods
Summary: Consider Conditional attribute in CodeGenerator for methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 67397 67406 67403
  Show dependency treegraph
 
Reported: 2011-09-01 08:25 PDT by Patrick R. Gansterer
Modified: 2011-09-01 15:41 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.24 KB, patch)
2011-09-01 08:29 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (22.49 KB, patch)
2011-09-01 10:26 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-09-01 08:25:00 PDT
Consider Conditional attribute in CodeGeneratorJS for PrototypeFunction
Comment 1 Patrick R. Gansterer 2011-09-01 08:29:57 PDT
Created attachment 105970 [details]
Patch
Comment 2 Darin Adler 2011-09-01 10:02:42 PDT
Comment on attachment 105970 [details]
Patch

You should add a binding test when you change how bindings work.

You can run the bindings tests like this:

    run-bindings-tests

You can generate new test results after changing the test input like this:

    run-bindings-tests --reset-results

Your patch should include both changes to the test IDL files and the changes to the expected result files.
Comment 3 Patrick R. Gansterer 2011-09-01 10:26:12 PDT
Created attachment 105988 [details]
Patch
Comment 4 WebKit Review Bot 2011-09-01 15:41:28 PDT
Comment on attachment 105988 [details]
Patch

Clearing flags on attachment: 105988

Committed r94354: <http://trac.webkit.org/changeset/94354>
Comment 5 WebKit Review Bot 2011-09-01 15:41:32 PDT
All reviewed patches have been landed.  Closing bug.