Bug 67403 - Replace ENABLE_FULLSCREEN_API preprocessor statements in IDL files with Conditional attribute
Summary: Replace ENABLE_FULLSCREEN_API preprocessor statements in IDL files with Condi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 67409 67450
Blocks: 67400
  Show dependency treegraph
 
Reported: 2011-09-01 07:50 PDT by Patrick R. Gansterer
Modified: 2018-05-23 06:36 PDT (History)
9 users (show)

See Also:


Attachments
Patch (2.74 KB, patch)
2011-09-01 07:52 PDT, Patrick R. Gansterer
darin: review-
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Patch (4.47 KB, patch)
2013-04-10 03:43 PDT, Patrick R. Gansterer
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-09-01 07:50:08 PDT
Replace ENABLE_FULLSCREEN_API preprocessor statements in IDL files with Conditional attribute
Comment 1 Patrick R. Gansterer 2011-09-01 07:52:46 PDT
Created attachment 105962 [details]
Patch
Comment 2 Gyuyoung Kim 2011-09-01 07:57:59 PDT
Comment on attachment 105962 [details]
Patch

Attachment 105962 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9582254
Comment 3 Early Warning System Bot 2011-09-01 08:04:49 PDT
Comment on attachment 105962 [details]
Patch

Attachment 105962 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9586010
Comment 4 Darin Adler 2011-09-01 09:58:41 PDT
Comment on attachment 105962 [details]
Patch

Broke the Qt and EFL builds. Need to resolve that before doing this.
Comment 5 Patrick R. Gansterer 2013-04-10 03:43:20 PDT
Created attachment 197238 [details]
Patch
Comment 6 Build Bot 2013-04-10 04:02:46 PDT
Comment on attachment 197238 [details]
Patch

Attachment 197238 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17671047
Comment 7 Build Bot 2013-04-10 04:33:42 PDT
Comment on attachment 197238 [details]
Patch

Attachment 197238 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17722132
Comment 8 Frédéric Wang (:fredw) 2018-05-23 06:36:44 PDT
Source/WebCore/dom/Document.idl now uses the Conditional attribute.