Bug 67397 - Replace ENABLE_BLOB preprocessor statements in IDL files with Conditional attribute
Summary: Replace ENABLE_BLOB preprocessor statements in IDL files with Conditional att...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 67409
Blocks: 67400
  Show dependency treegraph
 
Reported: 2011-09-01 07:18 PDT by Patrick R. Gansterer
Modified: 2011-09-02 05:55 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.94 KB, patch)
2011-09-01 07:26 PDT, Patrick R. Gansterer
darin: review-
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Patch (2.94 KB, patch)
2011-09-01 15:53 PDT, Patrick R. Gansterer
webkit-ews: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-09-01 07:18:29 PDT
Replace ENABLE_BLOB preprocessor statements in IDL files with Conditional attribute
Comment 1 Patrick R. Gansterer 2011-09-01 07:26:44 PDT
Created attachment 105956 [details]
Patch
Comment 2 Gyuyoung Kim 2011-09-01 07:31:45 PDT
Comment on attachment 105956 [details]
Patch

Attachment 105956 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9572993
Comment 3 Darin Adler 2011-09-01 09:56:06 PDT
Comment on attachment 105956 [details]
Patch

EWS server says this does not build on Windows or EFL yet. Idea of the change is fine, but we have to inure out what’s wrong before landing this.
Comment 4 Patrick R. Gansterer 2011-09-01 15:53:28 PDT
Created attachment 106050 [details]
Patch

reupload the same patch again, since bug 67409 landed in the meantime
Comment 5 Early Warning System Bot 2011-09-01 16:08:48 PDT
Comment on attachment 106050 [details]
Patch

Attachment 106050 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9583372
Comment 6 WebKit Review Bot 2011-09-01 17:05:43 PDT
Comment on attachment 106050 [details]
Patch

Attachment 106050 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9582431
Comment 7 Gyuyoung Kim 2011-09-01 17:41:09 PDT
Comment on attachment 106050 [details]
Patch

Attachment 106050 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9580443
Comment 8 Collabora GTK+ EWS bot 2011-09-01 23:35:20 PDT
Comment on attachment 106050 [details]
Patch

Attachment 106050 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9582548