Bug 67406 - Replace ENABLE_VIDEO preprocessor statements in IDL files with Conditional attribute
Summary: Replace ENABLE_VIDEO preprocessor statements in IDL files with Conditional at...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 67409
Blocks: 67400
  Show dependency tree / graph
 
Reported: 2011-09-01 07:56 PDT by Patrick R. Gansterer
Modified: 2023-12-28 08:30 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.72 KB, patch)
2011-09-01 07:58 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (5.86 KB, patch)
2011-09-01 16:08 PDT, Patrick R. Gansterer 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-09-01 07:56:33 PDT 
Replace ENABLE_VIDEO preprocessor statements in IDL files with Conditional attribute
Comment 1 Patrick R. Gansterer 2011-09-01 07:58:06 PDT 
Created attachment 105964 [details]
Patch
Comment 2 Gyuyoung Kim 2011-09-01 08:05:17 PDT 
Comment on attachment 105964 [details]
Patch

Attachment 105964 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9578425
Comment 3 Darin Adler 2011-09-01 09:59:13 PDT 
Comment on attachment 105964 [details]
Patch

Broke the EFL build. Need to resolve that before landing this.
Comment 4 Patrick R. Gansterer 2011-09-01 16:08:17 PDT 
Created attachment 106055 [details]
Patch
Comment 5 Early Warning System Bot 2011-09-01 16:39:55 PDT 
Comment on attachment 106055 [details]
Patch

Attachment 106055 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9581479
Comment 6 WebKit Review Bot 2011-09-01 16:52:00 PDT 
Comment on attachment 106055 [details]
Patch

Attachment 106055 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9579514
Comment 7 Gyuyoung Kim 2011-09-01 17:51:01 PDT 
Comment on attachment 106055 [details]
Patch

Attachment 106055 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9583419
Comment 8 Collabora GTK+ EWS bot 2011-09-01 23:39:34 PDT 
Comment on attachment 106055 [details]
Patch

Attachment 106055 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9582553
Comment 9 Anne van Kesteren 2023-12-28 08:30:19 PST 
This seems to have by-and-large happened, except for some instances where the Conditional attribute doesn't work.