Bug 65889 - Implement <input type=color> UI behavior WebKit mac part
Summary: Implement <input type=color> UI behavior WebKit mac part
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords:
Depends on:
Blocks: 61276
  Show dependency tree / graph
 
Reported: 2011-08-08 16:53 PDT by Keishi Hattori
Modified: 2013-03-28 02:24 PDT (History)
3 users (show)

See Also:

Attachments
patch (11.41 KB, patch)
2011-08-09 20:50 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2011-08-08 16:53:14 PDT 
implement ChromeClient::openColorChooser, closeColorChooser, and setSelectedColorInColorChooser for WebKit mac
Comment 1 Keishi Hattori 2011-08-09 20:50:46 PDT 
Created attachment 103437 [details]
patch
Comment 2 Keishi Hattori 2011-08-25 05:43:04 PDT 
Comment on attachment 103437 [details]
patch

Obsoleting patch. I will be changing the NSColorPanel behavior to match OS X.
Comment 3 Jon Lee 2012-02-01 12:12:28 PST 
Is there a status update on this? Is there a way I can help, or take the bug?
Comment 4 Keishi Hattori 2012-02-01 17:19:12 PST 
Right now I am trying to land the patch for the Chromium side.
I tried to implement it for Safari but I have given up because it requires modifying Safari.
Please take this bug :)
Comment 5 Jon Lee 2012-02-01 17:23:42 PST 
Sure! I tried to enable INPUT_COLOR and it looks like there were some loose ends that didn't get checked in (like a missing virtual destructor in ColorChooserClient), aside from just impl'ing the client. Are those part of your patches that haven't been checked in yet, or are they part of another bug?
Comment 6 Keishi Hattori 2012-02-02 20:02:38 PST 
(In reply to comment #5)
> Sure! I tried to enable INPUT_COLOR and it looks like there were some loose ends that didn't get checked in (like a missing virtual destructor in ColorChooserClient), aside from just impl'ing the client. Are those part of your patches that haven't been checked in yet, or are they part of another bug?

I've uploaded patches Bug 77698, Bug 77699, Bug 77701 to fix bugs I know about.