Bug 77699 - ColorInputType needs to use ensureInlineStyleDecl
Summary: ColorInputType needs to use ensureInlineStyleDecl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-02 18:22 PST by Keishi Hattori
Modified: 2012-02-02 21:44 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.29 KB, patch)
2012-02-02 19:07 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (1.43 KB, patch)
2012-02-02 19:30 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-02-02 18:22:05 PST 
Change ColorInputType to use ensureInlineStyleDecl.
Comment 1 Keishi Hattori 2012-02-02 19:07:57 PST 
Created attachment 125234 [details]
Patch
Comment 2 Kent Tamura 2012-02-02 19:20:31 PST 
Comment on attachment 125234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125234&action=review

> Source/WebCore/ChangeLog:7
> +        ColorInputType needs to use ensureInlineStyleDecl
> +        https://bugs.webkit.org/show_bug.cgi?id=77699
> +
> +        Reviewed by NOBODY (OOPS!).
> +

You had better add a reason that we need ensureInlineStyleDecl.
Comment 3 Keishi Hattori 2012-02-02 19:30:20 PST 
Created attachment 125241 [details]
Patch
Comment 4 Keishi Hattori 2012-02-02 19:31:59 PST 
Comment on attachment 125241 [details]
Patch

Added comment.

Because WebCore internally should use the more specific CSSMutableStyleDeclaration
http://trac.webkit.org/changeset/105739
Comment 5 WebKit Review Bot 2012-02-02 21:44:50 PST 
Comment on attachment 125241 [details]
Patch

Clearing flags on attachment: 125241

Committed r106628: <http://trac.webkit.org/changeset/106628>
Comment 6 WebKit Review Bot 2012-02-02 21:44:54 PST 
All reviewed patches have been landed.  Closing bug.