Bug 77701 - Remove OVERRIDE from ColorInputType::valueAsColor
Summary: Remove OVERRIDE from ColorInputType::valueAsColor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-02 18:26 PST by Keishi Hattori
Modified: 2012-02-07 12:39 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2012-02-02 18:31 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (1.51 KB, patch)
2012-02-02 19:10 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-02-02 18:26:22 PST 
Remove OVERRIDE from ColorInputType::valueAsColor, it was a mistake.
Comment 1 Keishi Hattori 2012-02-02 18:31:03 PST 
Created attachment 125226 [details]
Patch
Comment 2 Kent Tamura 2012-02-02 19:04:52 PST 
Comment on attachment 125226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125226&action=review

> Source/WebCore/html/ColorInputType.h:57
> -    virtual Color valueAsColor() const OVERRIDE;
> +    virtual Color valueAsColor() const;

Do we need virtual?
Comment 3 Keishi Hattori 2012-02-02 19:10:33 PST 
Created attachment 125235 [details]
Patch
Comment 4 Kent Tamura 2012-02-02 19:11:17 PST 
Comment on attachment 125235 [details]
Patch

ok
Comment 5 WebKit Review Bot 2012-02-02 21:14:56 PST 
Comment on attachment 125235 [details]
Patch

Clearing flags on attachment: 125235

Committed r106624: <http://trac.webkit.org/changeset/106624>
Comment 6 WebKit Review Bot 2012-02-02 21:15:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Darin Adler 2012-02-07 12:39:12 PST 
Hooray, this is just what OVERRIDE is for! Without OVERRIDE we probably would have had an unnecessary virtual function.