Bug 51551 - [chromium] warnings when building on Windows
Summary: [chromium] warnings when building on Windows
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
Depends on: 50982 51553 51554 51566 51963 51964 51965
  Show dependency treegraph
Reported: 2010-12-23 12:12 PST by Evan Martin
Modified: 2013-04-11 13:00 PDT (History)
3 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Evan Martin 2010-12-23 12:12:32 PST
We still get a few warnings when we build on Windows.  We should fix these, and then make warnings into errors so that they don't regress.

Here is a full list from a recent run:

e:\b\build\slave\win\build\src\third_party\WebKit\Tools\DumpRenderTree\TestNetscapePlugIn\Tests\NPRuntimeRemoveProperty.cpp(66) : warning C4244: 'initializing' : conversion from 'const double' to 'int32_t', possible loss of data

e:\b\build\slave\win\build\src\third_party\webkit\webcore\dom\ViewportArguments.h(78) : warning C4305: 'initializing' : truncation from '' to 'bool'
(this is bug 50982 and the code is truly wrong, possibly causing real problems)

e:\b\build\slave\win\build\src\third_party\WebKit\Tools\DumpRenderTree\chromium\LayoutTestController.cpp(1433) : warning C4244: 'argument' : conversion from 'float' to 'int', possible loss of data
Comment 1 Evan Martin 2010-12-23 13:17:10 PST
Oops, left one out:
..\html\TextMetrics.h(39) : warning C4244: 'return' : conversion from 'const float' to 'unsigned int', possible loss of data
Comment 2 Evan Martin 2010-12-23 13:19:19 PST
James, I'm trying to fix all the Windows build warnings.
One of the last one is near a comment you added:

+    // FIXME: Is coercing to an integer value intentional? If so, there should be a static_cast<unsigned>() here.
     unsigned width() const { return m_width; }

Did you ever track down that issue?
Comment 3 Evan Martin 2010-12-23 13:19:36 PST
(see bug 38073 for more context)
Comment 4 Evan Martin 2010-12-23 15:25:32 PST
CC original author of the mystery code.
Comment 5 Evan Martin 2010-12-23 15:25:48 PST
Oops, sorry hyatt, wrong bug.  :(