Bug 51553 – [chromium] LayoutTestController warning in float->int conversion

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Evan Martin]

[chromium] LayoutTestController warning in float->int conversion

[Evan Martin]

Created attachment 77359 [details]
Patch

[Evan Martin]

Who does Chromium LayoutTestController reviews?  Help me find a reviewer.  :)

[Ryosuke Niwa]

Comment on attachment 77359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77359&action=review

> Tools/DumpRenderTree/chromium/LayoutTestController.cpp:1383
> -                                    float* pageWidthInPixels,
> -                                    float* pageHeightInPixels)
> +                                    int* pageWidthInPixels,
> +                                    int* pageHeightInPixels)

Why don't we use reference?

[Evan Martin]

I don't know, is that more common in WebKit?  I didn't do it because
1) I wanted to stick the the behavior of the old code and
2) using references for that isn't allowed in Google style, so it didn't occur to me.  :)

[Ryosuke Niwa]

Comment on attachment 77359 [details]
Patch

(In reply to comment #4)
> I don't know, is that more common in WebKit?

I think so.

> 1) I wanted to stick the the behavior of the old code and
> 2) using references for that isn't allowed in Google style, so it didn't occur to me.  :)

Ok, r=me. This change is simple enough.

[Ryosuke Niwa]

By the way, you should add yourself to http://trac.webkit.org/wiki/WebKit%20Team.

[WebKit Commit Bot]

Comment on attachment 77359 [details]
Patch

Clearing flags on attachment: 77359

Committed r74598: <http://trac.webkit.org/changeset/74598>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.