Bug 51553 - [chromium] LayoutTestController warning in float->int conversion
Summary: [chromium] LayoutTestController warning in float->int conversion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Evan Martin
URL:
Keywords:
Depends on:
Blocks: 51551
  Show dependency tree / graph
 
Reported: 2010-12-23 12:32 PST by Evan Martin
Modified: 2010-12-23 17:19 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.75 KB, patch)
2010-12-23 12:34 PST, Evan Martin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Martin 2010-12-23 12:32:33 PST 
[chromium] LayoutTestController warning in float->int conversion
Comment 1 Evan Martin 2010-12-23 12:34:43 PST 
Created attachment 77359 [details]
Patch
Comment 2 Evan Martin 2010-12-23 12:37:25 PST 
Who does Chromium LayoutTestController reviews?  Help me find a reviewer.  :)
Comment 3 Ryosuke Niwa 2010-12-23 13:23:16 PST 
Comment on attachment 77359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77359&action=review

> Tools/DumpRenderTree/chromium/LayoutTestController.cpp:1383
> -                                    float* pageWidthInPixels,
> -                                    float* pageHeightInPixels)
> +                                    int* pageWidthInPixels,
> +                                    int* pageHeightInPixels)

Why don't we use reference?
Comment 4 Evan Martin 2010-12-23 13:26:43 PST 
I don't know, is that more common in WebKit?  I didn't do it because
1) I wanted to stick the the behavior of the old code and
2) using references for that isn't allowed in Google style, so it didn't occur to me.  :)
Comment 5 Ryosuke Niwa 2010-12-23 13:32:29 PST 
Comment on attachment 77359 [details]
Patch

(In reply to comment #4)
> I don't know, is that more common in WebKit?

I think so.

> 1) I wanted to stick the the behavior of the old code and
> 2) using references for that isn't allowed in Google style, so it didn't occur to me.  :)

Ok, r=me. This change is simple enough.
Comment 6 Ryosuke Niwa 2010-12-23 13:34:16 PST 
By the way, you should add yourself to http://trac.webkit.org/wiki/WebKit%20Team.
Comment 7 WebKit Commit Bot 2010-12-23 17:19:15 PST 
Comment on attachment 77359 [details]
Patch

Clearing flags on attachment: 77359

Committed r74598: <http://trac.webkit.org/changeset/74598>
Comment 8 WebKit Commit Bot 2010-12-23 17:19:22 PST 
All reviewed patches have been landed.  Closing bug.