Bug 50316 - Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGLength
Summary: Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGLength
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 42025 50322 50323 50383 50440
  Show dependency treegraph
 
Reported: 2010-12-01 02:27 PST by Nikolas Zimmermann
Modified: 2010-12-03 00:43 PST (History)
2 users (show)

See Also:


Attachments
Patch (90.57 KB, patch)
2010-12-01 02:29 PST, Nikolas Zimmermann
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-12-01 02:27:01 PST
Split DECLARE_ANIMATED_PROPERTY_NEW in two macros: DECLARE/DEFINE_ANIMATED_PROPERTY, to avoid having to include SVGNames.h in the headers, that only want to declare the animated properties.
Create simple DECLARE_ANIMATED_LENGTH / DEFINE_ANIMATED_LENGTH macro pairs, and deploy them everywhere, as first step.
Comment 1 Nikolas Zimmermann 2010-12-01 02:29:41 PST
Created attachment 75262 [details]
Patch

Starting to convert SVGLength. The global SVGNames.h will go away, as soon as all types are converted.
But it's only a simple mechanical task, it should be done soon....
Comment 2 Xan Lopez 2010-12-01 03:32:44 PST
Comment on attachment 75262 [details]
Patch

I think this is one good example of a patch where mixing style fixes makes things harder to read :)

Looks reasonable to me otherwise. You might want to get rid of the file list in the ChangeLog if you are not going to use it to add inline comments, since it's pretty big.
Comment 3 Nikolas Zimmermann 2010-12-01 04:11:57 PST
(In reply to comment #2)
> (From update of attachment 75262 [details])
> I think this is one good example of a patch where mixing style fixes makes things harder to read :)

True, I just had to do the changes, to make the style bot happy... :-)
Comment 4 Nikolas Zimmermann 2010-12-01 07:18:38 PST
Landed in r70316.