RESOLVED FIXED 42025
1336 files in WebCore rebuild when you touch SVGNames 
https://bugs.webkit.org/show_bug.cgi?id=42025
Summary 1336 files in WebCore rebuild when you touch SVGNames
Eric Seidel (no email)
Reported 2010-07-10 02:12:02 PDT
1336 files in WebCore rebuild when you touch SVGNames Something in the dependency chain is very broken.
Attachments
Patch (19.54 KB, patch)
2010-12-03 03:00 PST, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-07-10 02:13:00 PDT
I think this is mostly caused by DECLARE_ANIMATED_PROPERTY taking a QualifiedName parameter. WildFox says that parameter isn't even used anymore. This could be a noticeable codesize reduction in the intermediate files. SVGNames.h is not a small include.
Eric Seidel (no email)
Comment 2 2010-07-10 23:26:38 PDT
PassRefPtr<SVGAnimatedPropertyTearOff##UpperProperty> LowerProperty##Animated() \ { \ SVGElement* contextElement = GetOwnerElementForType<OwnerType, IsDerivedFromSVGElement<OwnerType>::value>::ownerElement(this); \ return lookupOrCreateWrapper<AnimatedType, SVGAnimatedPropertyTearOff##UpperProperty>(contextElement, m_##LowerProperty, DOMAttribute); \ } Still uses DOMAttribute from the _DECLARE macro. Seems we'll need to move that to the .cpp if we want to get rid of this crazy SVGNames sprawl.
Nikolas Zimmermann
Comment 3 2010-12-01 02:07:06 PST
Now that 47905 is completly fixed, I'm working on removing the SVGNames.h dependency, a first patch covering SVGLength will be uploaded soon.
Nikolas Zimmermann
Comment 4 2010-12-03 03:00:28 PST
Created attachment 75485 [details] Patch
Dirk Schulze
Comment 5 2010-12-03 03:02:56 PST
Comment on attachment 75485 [details] Patch LGTM. r=me
Nikolas Zimmermann
Comment 6 2010-12-03 03:15:02 PST
Landed in r73258, hopefully making Eric happy :-)
Eric Seidel (no email)
Comment 7 2010-12-03 08:35:00 PST
Yay!
Note You need to log in before you can comment on or make changes to this bug.