Bug 42025 - 1336 files in WebCore rebuild when you touch SVGNames
Summary: 1336 files in WebCore rebuild when you touch SVGNames
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
Depends on: 47905 50316 50322 50323 50383 50440
  Show dependency treegraph
Reported: 2010-07-10 02:12 PDT by Eric Seidel (no email)
Modified: 2010-12-03 08:35 PST (History)
2 users (show)

See Also:

Patch (19.54 KB, patch)
2010-12-03 03:00 PST, Nikolas Zimmermann
krit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-07-10 02:12:02 PDT
1336 files in WebCore rebuild when you touch SVGNames

Something in the dependency chain is very broken.
Comment 1 Eric Seidel (no email) 2010-07-10 02:13:00 PDT
I think this is mostly caused by DECLARE_ANIMATED_PROPERTY taking a QualifiedName parameter.

WildFox says that parameter isn't even used anymore.

This could be a noticeable codesize reduction in the intermediate files.  SVGNames.h is not a small include.
Comment 2 Eric Seidel (no email) 2010-07-10 23:26:38 PDT
    PassRefPtr<SVGAnimatedPropertyTearOff##UpperProperty> LowerProperty##Animated() \
    { \
        SVGElement* contextElement = GetOwnerElementForType<OwnerType, IsDerivedFromSVGElement<OwnerType>::value>::ownerElement(this); \
        return lookupOrCreateWrapper<AnimatedType, SVGAnimatedPropertyTearOff##UpperProperty>(contextElement, m_##LowerProperty, DOMAttribute); \

Still uses DOMAttribute from the _DECLARE macro.  Seems we'll need to move that to the .cpp if we want to get rid of this crazy SVGNames sprawl.
Comment 3 Nikolas Zimmermann 2010-12-01 02:07:06 PST
Now that 47905 is completly fixed, I'm working on removing the SVGNames.h dependency, a first patch covering SVGLength will be uploaded soon.
Comment 4 Nikolas Zimmermann 2010-12-03 03:00:28 PST
Created attachment 75485 [details]
Comment 5 Dirk Schulze 2010-12-03 03:02:56 PST
Comment on attachment 75485 [details]

LGTM. r=me
Comment 6 Nikolas Zimmermann 2010-12-03 03:15:02 PST
Landed in r73258, hopefully making Eric happy :-)
Comment 7 Eric Seidel (no email) 2010-12-03 08:35:00 PST