Bug 50440 - Finish splitting DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for the remaining SVGAnimated* types
Summary: Finish splitting DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for the r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on: 50316
Blocks: 42025
  Show dependency treegraph
 
Reported: 2010-12-03 00:43 PST by Nikolas Zimmermann
Modified: 2010-12-03 01:45 PST (History)
5 users (show)

See Also:


Attachments
Patch (93.04 KB, patch)
2010-12-03 00:47 PST, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Patch v2 (93.69 KB, patch)
2010-12-03 01:27 PST, Nikolas Zimmermann
krit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-12-03 00:43:57 PST
Same work as bug 50316, but for SVGAnimatedBoolean/SVGAnimatedAngle/SVGAnimatedRect.
This marks the end of the split patch series. After this lands the global SVGNames.h include problem can be fixed.
Comment 1 Nikolas Zimmermann 2010-12-03 00:47:19 PST
Created attachment 75470 [details]
Patch
Comment 2 Early Warning System Bot 2010-12-03 01:04:39 PST
Attachment 75470 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6781023
Comment 3 WebKit Review Bot 2010-12-03 01:11:00 PST
Attachment 75470 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6753025
Comment 4 Dirk Schulze 2010-12-03 01:11:39 PST
Comment on attachment 75470 [details]
Patch

LGTM. Please fix the style error, if there is one. Don't you use webkit upload? If not, please check the style with check-webkit-style before you commit a patch - always.

r=me
Comment 5 Dirk Schulze 2010-12-03 01:12:46 PST
Comment on attachment 75470 [details]
Patch

Clearing r+ because of build breaks on some bots.
Comment 6 Build Bot 2010-12-03 01:26:02 PST
Attachment 75470 [details] did not build on win:
Build output: http://queues.webkit.org/results/6805023
Comment 7 Nikolas Zimmermann 2010-12-03 01:27:51 PST
Created attachment 75473 [details]
Patch v2
Comment 8 Dirk Schulze 2010-12-03 01:39:19 PST
Comment on attachment 75473 [details]
Patch v2

r=me
Comment 9 Nikolas Zimmermann 2010-12-03 01:45:14 PST
Landed in r73254.