WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
50383
Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGAnimatedString/SVGAnimatedEnumeration
https://bugs.webkit.org/show_bug.cgi?id=50383
Summary
Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGAnimatedStrin...
Nikolas Zimmermann
Reported
2010-12-02 06:34:31 PST
Same work as
bug 50316
, but for SVGAnimatedNumber.
Attachments
Patch
(81.33 KB, patch)
2010-12-02 06:39 PST
,
Nikolas Zimmermann
no flags
Details
Formatted Diff
Diff
Patch v2
(81.33 KB, patch)
2010-12-02 06:46 PST
,
Nikolas Zimmermann
aroben
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1
2010-12-02 06:34:51 PST
Erm for SVGAnimatedString/SVGAnimatedEnumeration, not SVGAnimatedNumber (copy-paste error ;-)
Nikolas Zimmermann
Comment 2
2010-12-02 06:39:07 PST
Created
attachment 75371
[details]
Patch
Nikolas Zimmermann
Comment 3
2010-12-02 06:46:01 PST
Created
attachment 75373
[details]
Patch v2 Oops, uploaded the wrong version, ignore the first patch.
Early Warning System Bot
Comment 4
2010-12-02 06:56:24 PST
Attachment 75371
[details]
did not build on qt: Build output:
http://queues.webkit.org/results/6799009
Nikolas Zimmermann
Comment 5
2010-12-02 07:09:11 PST
Ran check-webkit-style locally as the style bot doesn't post results :(( Fixed two tab usages, and two include order problems.
Adam Roben (:aroben)
Comment 6
2010-12-02 07:09:58 PST
Comment on
attachment 75373
[details]
Patch v2 View in context:
https://bugs.webkit.org/attachment.cgi?id=75373&action=review
It would be slightly nicer to do the un-indenting separately.
> WebCore/svg/SVGAElement.h:68 > + // This defines a non-virtual "String& target() const" method before, that would clash with "virtual String target() const" > + // in Element. That's why it's now named "String& svgTarget() const", to avoid the clash. The CodeGenerators take care
The first sentence here seems a little garbled. And I think you mean "declares" instead of "defines".
Build Bot
Comment 7
2010-12-02 07:18:59 PST
Attachment 75371
[details]
did not build on win: Build output:
http://queues.webkit.org/results/6776008
Nikolas Zimmermann
Comment 8
2010-12-03 00:42:29 PST
Landed in
r73130
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug