Bug 50383 - Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGAnimatedString/SVGAnimatedEnumeration
Summary: Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGAnimatedStrin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on: 50316
Blocks: 42025
  Show dependency treegraph
 
Reported: 2010-12-02 06:34 PST by Nikolas Zimmermann
Modified: 2010-12-03 00:42 PST (History)
5 users (show)

See Also:


Attachments
Patch (81.33 KB, patch)
2010-12-02 06:39 PST, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Patch v2 (81.33 KB, patch)
2010-12-02 06:46 PST, Nikolas Zimmermann
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-12-02 06:34:31 PST
Same work as bug 50316, but for SVGAnimatedNumber.
Comment 1 Nikolas Zimmermann 2010-12-02 06:34:51 PST
Erm for SVGAnimatedString/SVGAnimatedEnumeration, not SVGAnimatedNumber (copy-paste error ;-)
Comment 2 Nikolas Zimmermann 2010-12-02 06:39:07 PST
Created attachment 75371 [details]
Patch
Comment 3 Nikolas Zimmermann 2010-12-02 06:46:01 PST
Created attachment 75373 [details]
Patch v2

Oops, uploaded the wrong version, ignore the first patch.
Comment 4 Early Warning System Bot 2010-12-02 06:56:24 PST
Attachment 75371 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6799009
Comment 5 Nikolas Zimmermann 2010-12-02 07:09:11 PST
Ran check-webkit-style locally as the style bot doesn't post results :((
Fixed two tab usages, and two include order problems.
Comment 6 Adam Roben (:aroben) 2010-12-02 07:09:58 PST
Comment on attachment 75373 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=75373&action=review

It would be slightly nicer to do the un-indenting separately.

> WebCore/svg/SVGAElement.h:68
> +    // This defines a non-virtual "String& target() const" method before, that would clash with "virtual String target() const"
> +    // in Element. That's why it's now named "String& svgTarget() const", to avoid the clash. The CodeGenerators take care

The first sentence here seems a little garbled. And I think you mean "declares" instead of "defines".
Comment 7 Build Bot 2010-12-02 07:18:59 PST
Attachment 75371 [details] did not build on win:
Build output: http://queues.webkit.org/results/6776008
Comment 8 Nikolas Zimmermann 2010-12-03 00:42:29 PST
Landed in r73130.