WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
41321
MASTER: Use std::make_unique or adoptRef at all call sites where new is used
https://bugs.webkit.org/show_bug.cgi?id=41321
Summary
MASTER: Use std::make_unique or adoptRef at all call sites where new is used
Darin Adler
Reported
2010-06-28 17:51:02 PDT
Working on a project where we will always adopt right after we call new.
Attachments
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2011-12-25 19:46:24 PST
Command line I am using to find additional call sites for new: find . -name '*.cpp' -o -name '*.mm' | xargs grep "new [a-zA-Z]" | grep -v adoptArrayPtr | grep -v adoptPtr | grep -v adoptRef | grep -v rena | grep -v ":[ \t]*/" | grep -v static | grep -v s_
Darin Adler
Comment 2
2019-04-21 14:18:29 PDT
Changed my mind. We should minimize the use of direct calls to "new", but it’s impractical to forbid it entirely, I think.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug