RESOLVED FIXED Bug 28068
Make DOM classes start with a reference count of 1, like all other RefCounted 
https://bugs.webkit.org/show_bug.cgi?id=28068
Summary Make DOM classes start with a reference count of 1, like all other RefCounted
Darin Adler
Reported 2009-08-07 08:15:37 PDT
Working on it.
Attachments
work in progress (104.80 KB, patch)
2009-08-07 08:16 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch (122.25 KB, patch)
2009-08-10 18:03 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
work in progress (83.74 KB, patch)
2009-08-17 01:34 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
work in progress (81.95 KB, patch)
2009-08-18 10:32 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Factored-out preparation piece (38.69 KB, patch)
2009-08-18 10:34 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch 2 (66.32 KB, patch)
2009-08-19 02:22 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (81.84 KB, patch)
2010-08-30 22:56 PDT, Darin Adler 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2009-08-07 08:16:00 PDT
Created attachment 34274 [details] work in progress
Darin Adler
Comment 2 2009-08-10 18:03:11 PDT
Created attachment 34532 [details] patch
Sam Weinig
Comment 3 2009-08-14 18:49:51 PDT
Comment on attachment 34532 [details] patch Beautiful. r=me.
Darin Adler
Comment 4 2009-08-14 23:26:36 PDT
Comment on attachment 34532 [details] patch Landed as http://trac.webkit.org/changeset/47313
Darin Adler
Comment 5 2009-08-17 01:34:48 PDT
Created attachment 34964 [details] work in progress
Darin Adler
Comment 6 2009-08-18 10:32:27 PDT
Created attachment 35049 [details] work in progress
Darin Adler
Comment 7 2009-08-18 10:34:19 PDT
Created attachment 35050 [details] Factored-out preparation piece
Darin Adler
Comment 8 2009-08-18 22:54:07 PDT
Comment on attachment 35050 [details] Factored-out preparation piece Landed as http://trac.webkit.org/changeset/47469
Darin Adler
Comment 9 2009-08-19 02:22:40 PDT
Created attachment 35112 [details] patch 2
Oliver Hunt
Comment 10 2009-08-21 01:33:18 PDT
Comment on attachment 35112 [details] patch 2 r=me -- in future could you try not to do unrelated code changes -- a lot of this patch was cleanup (making methods protected or private, etc) and that clouded a lot of what was going on.
Darin Adler
Comment 11 2009-08-22 23:53:24 PDT
(In reply to comment #10) > (From update of attachment 35112 [details]) > r=me -- in future could you try not to do unrelated code changes -- a lot of > this patch was cleanup (making methods protected or private, etc) and that > clouded a lot of what was going on. I'd be happy to split up patches like this into smaller pieces. could have a separate "make functions private" patch for each class. Or one that covers multiple classes.
Darin Adler
Comment 12 2009-08-22 23:56:39 PDT
Comment on attachment 35112 [details] patch 2 Landed as http://trac.webkit.org/changeset/47688
Darin Adler
Comment 13 2010-08-30 22:56:01 PDT
Created attachment 66014 [details] Patch
Darin Adler
Comment 14 2010-08-31 10:09:07 PDT
Committed r66498: <http://trac.webkit.org/changeset/66498>
Lucas Forschler
Comment 15 2019-02-06 09:03:17 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.