Bug 75221 - Use OwnPtr to handle lifetime and deletion of FontFace objects
Summary: Use OwnPtr to handle lifetime and deletion of FontFace objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 41321
  Show dependency treegraph
 
Reported: 2011-12-25 21:08 PST by Darin Adler
Modified: 2012-01-08 22:25 PST (History)
3 users (show)

See Also:


Attachments
Patch (6.25 KB, patch)
2011-12-25 21:13 PST, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2011-12-25 21:08:59 PST
Use OwnPtr to handle lifetime and deletion of FontFace objects
Comment 1 Darin Adler 2011-12-25 21:13:22 PST
Created attachment 120523 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-28 13:12:40 PST
Comment on attachment 120523 [details]
Patch

Clearing flags on attachment: 120523

Committed r103779: <http://trac.webkit.org/changeset/103779>
Comment 3 WebKit Review Bot 2011-12-28 13:12:44 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Steve Block 2012-01-03 06:32:31 PST
This change removed an ASSERT from CSSFontFaceSource::getFontData() which we were sometimes hitting on Android. Is the removal intentional and if so, was the ASSERT erroneous? Thanks!
Comment 5 Darin Adler 2012-01-08 22:25:39 PST
(In reply to comment #4)
> This change removed an ASSERT from CSSFontFaceSource::getFontData() which we were sometimes hitting on Android. Is the removal intentional and if so, was the ASSERT erroneous? Thanks!

I removed the assertion by accident. I do not know whether the assertion is correct or not. We should probably add it back.