WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
40443
Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=40443
Summary
Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
Kenneth Russell
Reported
2010-06-10 14:04:07 PDT
CodeGeneratorJS.pm has been updated to support overloaded methods in
bug 38920
. The custom JSC bindings for WebGLRenderingContext's bufferData, texImage2D and texSubImage2D should now be deleted. This will simplify needed work to update the signatures for texImage2D and texSubImage2D for recent spec changes.
Attachments
Patch
(23.11 KB, patch)
2010-06-10 14:22 PDT
,
Kenneth Russell
dglazkov
: review+
kbr
: commit-queue-
Details
Formatted Diff
Diff
Revised patch
(23.43 KB, patch)
2010-06-10 17:52 PDT
,
Kenneth Russell
dglazkov
: review+
kbr
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Kenneth Russell
Comment 1
2010-06-10 14:06:42 PDT
***
Bug 38024
has been marked as a duplicate of this bug. ***
Kenneth Russell
Comment 2
2010-06-10 14:22:42 PDT
Created
attachment 58412
[details]
Patch From the ChangeLog: Deleted custom JSC bindings for bufferData, texImage2D and texSubImage2D and fixed minor associated issues in code generator and IDL. Updated fast/canvas/webgl/texImageTest-expected.txt, which now runs as intended. Ran all layout tests, including WebGL tests, in Safari. Note: full layout tests run still ongoing; will not commit until successfully completed.
Kenneth Russell
Comment 3
2010-06-10 14:32:16 PDT
(In reply to
comment #2
)
> Note: full layout tests run still ongoing; will not commit until successfully completed.
Layout tests all pass with the changes to the code generator.
Dimitri Glazkov (Google)
Comment 4
2010-06-10 14:51:10 PDT
Comment on
attachment 58412
[details]
Patch Awesome! Thanks kbr.
Kenneth Russell
Comment 5
2010-06-10 15:46:47 PDT
Committed
r60979
: <
http://trac.webkit.org/changeset/60979
>
Kenneth Russell
Comment 6
2010-06-10 17:05:27 PDT
The first patch broke the Leopard build due to bugs in the JSC code generation for overloaded methods, and I rolled it out in
https://bugs.webkit.org/show_bug.cgi?id=40450
. Reopening this and determining a revised fix.
Kenneth Russell
Comment 7
2010-06-10 17:52:41 PDT
Created
attachment 58427
[details]
Revised patch Added JSValue::encode to exception return path, needed on Leopard in particular. Built on Leopard and Snow Leopard; reran WebGL layout tests.
Dimitri Glazkov (Google)
Comment 8
2010-06-10 21:29:50 PDT
Comment on
attachment 58427
[details]
Revised patch Energize.
Kenneth Russell
Comment 9
2010-06-11 11:22:38 PDT
Committed
r61027
: <
http://trac.webkit.org/changeset/61027
>
Kenneth Russell
Comment 10
2010-08-05 12:30:26 PDT
***
Bug 32002
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug