Bug 40318 – Add texImage2D and texSubImage2D signatures with internal format, etc.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kenneth Russell]

Per recent updates to the WebGL spec:
 - New texImage2D entry points need to be added taking internalformat, format and type arguments, and removing the optional flipY and as asPremultipliedAlpha.
 - New texSubImage2D entry points need to be added taking format and type arguments, and removing the optional flipY and as asPremultipliedAlpha.
 - pixelStorei needs to be updated to take the new UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL enums. These must apply to all texImage2D and texSubImage2D variants.

The actual implementation of the format conversion should be deferred to another bug. Additionally, the existing entry points should be left in place for compatibility for a brief time.

[Kenneth Russell]

Implementing the UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA pixelStorei parameters for the texImage2D and texSubImage2D entry points taking ArrayBufferView will make this patch too large. This will be done in a separate fix.

[Kenneth Russell]

Created attachment 58508 [details]
Patch

From the ChangeLog:

Added new texImage2D and texSubImage2D entry points following WebGL specification changes. Added UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL pixelStorei parameters, honored them for the new entry points taking HTML elements, and added support to getParameter. Added warnings to the console for calls to the obsolete entry points, which will be removed in a few weeks. Updated all layout tests to use the new entry points and pixelStorei parameters, and associated expectations. No other new tests.

[Dimitri Glazkov (Google)]

Comment on attachment 58508 [details]
Patch

yay!

[Kenneth Russell]

Committed r61039: <http://trac.webkit.org/changeset/61039>

[WebKit Review Bot]

http://trac.webkit.org/changeset/61039 might have broken SnowLeopard Intel Release (Tests)

[Eric Seidel (no email)]

Bots are still broken:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r61043%20(11542)/fast/canvas/webgl/gl-get-calls-pretty-diff.html

[Kenneth Russell]

(In reply to comment #6)
> Bots are still broken:
> http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r61043%20(11542)/fast/canvas/webgl/gl-get-calls-pretty-diff.html

Yes, sorry. Fixing immediately:

https://bugs.webkit.org/show_bug.cgi?id=40506