Bug 32002 - Bug in custom JS bindings for texImage2D and texSubImage2D
Summary: Bug in custom JS bindings for texImage2D and texSubImage2D
Status: RESOLVED DUPLICATE of bug 40443
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-30 16:16 PST by Kenneth Russell
Modified: 2010-08-05 12:30 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2009-11-30 16:16:18 PST
I happened to notice via code inspection that the flipY and premultiplyAlpha boolean values are being set from the same incoming argument in the custom JS bindings for texImage2D and texSubImage2D. The errors are around lines 377-378 and 413-414 in WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp. I'm not sure whether GraphicsContext3DMac.cpp is supposed to handle the flipY argument properly yet, but if it is then this is probably why it isn't taking effect.
Comment 1 Oliver Hunt 2009-11-30 16:18:50 PST
(In reply to comment #0)
> I happened to notice via code inspection that the flipY and premultiplyAlpha
> boolean values are being set from the same incoming argument in the custom JS
> bindings for texImage2D and texSubImage2D. The errors are around lines 377-378
> and 413-414 in WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp. I'm not
> sure whether GraphicsContext3DMac.cpp is supposed to handle the flipY argument
> properly yet, but if it is then this is probably why it isn't taking effect.

irk, what i would give for autogen of variadic functions... :-/
Comment 2 Kenneth Russell 2010-08-05 12:30:26 PDT
This was implicitly fixed in the deletion of the custom JSC bindings for texImage2D in bug 40443.

*** This bug has been marked as a duplicate of bug 40443 ***