Bug 236754 - Safari produces scrambled output for some webm videos with vp8 codec.
Summary: Safari produces scrambled output for some webm videos with vp8 codec.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on: 237075 237078 237472 237594 237677
Blocks:
  Show dependency tree / graph
 
Reported: 2022-02-16 23:01 PST by Jean-Yves Avenard [:jya]
Modified: 2022-06-09 00:25 PDT (History)
8 users (show)

See Also:

Attachments
capture (5.78 MB, image/jpeg)
2022-02-16 23:01 PST, Jean-Yves Avenard [:jya] 		no flags Details
Patch for review (1.69 MB, patch)
2022-03-10 06:41 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch for EWS (1.70 MB, patch)
2022-03-10 06:43 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch (1.69 MB, patch)
2022-03-10 15:00 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch (213.82 KB, patch)
2022-03-12 04:37 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch (213.82 KB, patch)
2022-03-12 04:45 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch (215.15 KB, patch)
2022-03-12 21:44 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch (215.14 KB, patch)
2022-03-12 21:51 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2022-02-16 23:01:35 PST 
Created attachment 452323 [details]
capture

vp8 content with hidden frames won't be decoded properly.

https://jyavenard.github.io/htmltests/tests/mse_webm/80869041.html

Garbled output is produced.


rdar://80869041
Comment 1 Jean-Yves Avenard [:jya] 2022-03-10 06:41:11 PST 
Created attachment 454356 [details]
Patch for review
Comment 2 Jean-Yves Avenard [:jya] 2022-03-10 06:43:06 PST 
Created attachment 454357 [details]
Patch for EWS
Comment 3 Jean-Yves Avenard [:jya] 2022-03-10 15:00:00 PST 
Created attachment 454407 [details]
Patch

widen fuzz factor to cater for intermittent differences
Comment 4 Jean-Yves Avenard [:jya] 2022-03-12 04:37:00 PST 
Created attachment 454530 [details]
Patch
Comment 5 Jean-Yves Avenard [:jya] 2022-03-12 04:45:37 PST 
Created attachment 454532 [details]
Patch
Comment 6 Eric Carlson 2022-03-12 07:56:07 PST 
Comment on attachment 454532 [details]
Patch

Nice fix! My only nit, is I think it would be helpful to have to have the ffmpeg commands as comments in the html files where they are used, as well as in the ChangeLog
Comment 7 Jean-Yves Avenard [:jya] 2022-03-12 21:44:03 PST 
Created attachment 454548 [details]
Patch

Apply comments
Comment 8 Jean-Yves Avenard [:jya] 2022-03-12 21:45:48 PST 
(In reply to Eric Carlson from comment #6)
> Comment on attachment 454532 [details]
> Patch
> 
> Nice fix! My only nit, is I think it would be helpful to have to have the
> ffmpeg commands as comments in the html files where they are used, as well
> as in the ChangeLog

I did put it in the LayoutTests/ChangeLog file, added it to the two html files as well.
Comment 9 EWS 2022-03-12 21:46:24 PST 
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 10 Jean-Yves Avenard [:jya] 2022-03-12 21:51:06 PST 
Created attachment 454549 [details]
Patch

Apply comments and set reviewer
Comment 11 EWS 2022-03-12 23:24:20 PST 
Committed r291216 (248371@main): <https://commits.webkit.org/248371@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454549 [details].