Bug 237078 - Have SourceBufferParserWebM use SharedBuffer internally
Summary: Have SourceBufferParserWebM use SharedBuffer internally
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on: 237075
Blocks: 236754 237472
  Show dependency tree / graph
 
Reported: 2022-02-23 03:50 PST by Jean-Yves Avenard [:jya]
Modified: 2022-03-08 16:16 PST (History)
2 users (show)

See Also:

Attachments
Patch (30.99 KB, patch)
2022-02-23 05:14 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch for EWS (40.03 KB, patch)
2022-02-23 05:22 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch (31.22 KB, patch)
2022-02-24 05:36 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch for EWS (40.70 KB, patch)
2022-02-24 05:37 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch (31.26 KB, patch)
2022-02-24 14:27 PST, Jean-Yves Avenard [:jya] 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (40.75 KB, patch)
2022-02-24 14:29 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch for review (31.24 KB, patch)
2022-02-24 18:53 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch (40.71 KB, patch)
2022-02-24 18:54 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2022-02-23 03:50:54 PST 
Sub-task of bug 236754.

We can simplify the inner workings of SourceBufferParserWebM by using SharedBuffer instead of building CMBlockBuffer progressively. We can reduce the amount of memory used as CMBlockBuffer always allocate more memory than is actually needed.

It will also simplify the resolution of bug 236754.
Comment 1 Radar WebKit Bug Importer 2022-02-23 04:12:13 PST 
<rdar://problem/89348752>
Comment 2 Jean-Yves Avenard [:jya] 2022-02-23 05:14:53 PST 
Created attachment 452964 [details]
Patch
Comment 3 Jean-Yves Avenard [:jya] 2022-02-23 05:22:23 PST 
Created attachment 452967 [details]
Patch for EWS
Comment 4 Jean-Yves Avenard [:jya] 2022-02-24 05:36:33 PST 
Created attachment 453094 [details]
Patch
Comment 5 Jean-Yves Avenard [:jya] 2022-02-24 05:37:09 PST 
Created attachment 453095 [details]
Patch for EWS
Comment 6 Jean-Yves Avenard [:jya] 2022-02-24 14:27:33 PST 
Created attachment 453138 [details]
Patch
Comment 7 Jean-Yves Avenard [:jya] 2022-02-24 14:29:31 PST 
Created attachment 453139 [details]
Patch
Comment 8 Jean-Yves Avenard [:jya] 2022-02-24 18:53:49 PST 
Created attachment 453163 [details]
Patch for review
Comment 9 Jean-Yves Avenard [:jya] 2022-02-24 18:54:43 PST 
Created attachment 453164 [details]
Patch
Comment 10 EWS 2022-03-08 16:16:38 PST 
Committed r291020 (248194@main): <https://commits.webkit.org/248194@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453163 [details].