RESOLVED FIXED237075
Add ability to convert FragmentedSharedBuffer to CMBlockBuffer 
https://bugs.webkit.org/show_bug.cgi?id=237075
Summary Add ability to convert FragmentedSharedBuffer to CMBlockBuffer
Jean-Yves Avenard [:jya]
Reported 2022-02-22 22:45:59 PST
Sub-task of bug 236754. We can simplify the rewrite of SourceBufferParserWebM by using SharedBuffers instead. Once we have built the SharedBuffer, we would want an easy way to convert it into a CMBlockBuffer without allocating memory or performing any copies.
Attachments
Patch (9.42 KB, patch)
2022-02-23 03:34 PST, Jean-Yves Avenard [:jya] 		no flags
DetailsFormatted DiffDiff
Patch (9.47 KB, patch)
2022-02-23 18:26 PST, Jean-Yves Avenard [:jya] 		no flags
DetailsFormatted DiffDiff
Patch (9.87 KB, patch)
2022-02-24 05:34 PST, Jean-Yves Avenard [:jya] 		no flags
DetailsFormatted DiffDiff
Patch (9.96 KB, patch)
2022-03-07 14:53 PST, Jean-Yves Avenard [:jya] 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-22 22:49:17 PST
<rdar://problem/89338447>
Jean-Yves Avenard [:jya]
Comment 2 2022-02-23 03:34:57 PST
Created attachment 452960 [details] Patch
Jean-Yves Avenard [:jya]
Comment 3 2022-02-23 18:26:16 PST
Created attachment 453063 [details] Patch
Jean-Yves Avenard [:jya]
Comment 4 2022-02-24 00:05:15 PST
Comment on attachment 453063 [details] Patch Unrelated failure, that code path isn't even used yet.
Jean-Yves Avenard [:jya]
Comment 5 2022-02-24 05:34:36 PST
Created attachment 453093 [details] Patch
Jer Noble
Comment 6 2022-03-07 14:01:51 PST
Comment on attachment 453093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453093&action=review > Source/WebCore/platform/SharedBuffer.cpp:162 > + if (element->segment->size() - offsetInSegment >= length) Is it possible for element->segment->size() to be < offsetInSegment? If not, maybe an ASSERT() that states such?
Jean-Yves Avenard [:jya]
Comment 7 2022-03-07 14:42:15 PST
Comment on attachment 453093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453093&action=review >> Source/WebCore/platform/SharedBuffer.cpp:162 >> + if (element->segment->size() - offsetInSegment >= length) > > Is it possible for element->segment->size() to be < offsetInSegment? If not, maybe an ASSERT() that states such? No, it's not possible. unless getSegmentForPosition is buggy and it's not :)
Jean-Yves Avenard [:jya]
Comment 8 2022-03-07 14:53:09 PST
Created attachment 454038 [details] Patch
EWS
Comment 9 2022-03-07 17:40:26 PST
Committed r290968 (248147@main): <https://commits.webkit.org/248147@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454038 [details].
Note You need to log in before you can comment on or make changes to this bug.