Bug 237677 - MediaSampleCursor should iterate over the samples contained in the MediaSamplesBlock
Summary: MediaSampleCursor should iterate over the samples contained in the MediaSampl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on: 237594
Blocks: 236754
  Show dependency tree / graph
 
Reported: 2022-03-09 14:36 PST by Jean-Yves Avenard [:jya]
Modified: 2022-03-10 14:01 PST (History)
7 users (show)

See Also:

Attachments
Patch (14.94 KB, patch)
2022-03-09 22:37 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2022-03-09 14:36:12 PST 
Sub-task of bug 236754.

In bug 237594; the MediaFormatReader was made to use MediaSamplesBlock as backend via MediaSampleRangeRequest's refactor.

However, it only ever uses the last sample of the block, which is okay for now as there's no producer that create MediaSamplesBlock with more than one sample in it.

However, the resolution for bug 236754 will change that pre-requisite. 

So we need the MediaSampleCursor to properly iterate over all the samples contained in the block.
Comment 1 Radar WebKit Bug Importer 2022-03-09 14:36:50 PST 
<rdar://problem/90058029>
Comment 2 Jean-Yves Avenard [:jya] 2022-03-09 22:37:19 PST 
Created attachment 454317 [details]
Patch
Comment 3 EWS 2022-03-10 14:01:26 PST 
Committed r291132 (248292@main): <https://commits.webkit.org/248292@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454317 [details].