Changes in r287388 are not enough, it can still happen that root hasn't been set to the SVGImage page when the wrapper are created. So, we can't actually create the wrappers with a reference to the root object as we did in r286767
Created attachment 448066 [details] Patch
Comment on attachment 448066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448066&action=review > Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp:35 > +static AccessibilityAtspi* s_currentAtspi; This smells like we may want to use “NeverDestroyed<AccessibilityAtspi>“ and provide instead a “::singleton()“ method. As far as I find from the code, only the WebProcess will have an instance (and only one) of this, which gets created in “WebProcess::platformInitializeWebProcess()”. Then we could ditch the “WebProcess::m_accessibility” member and the “WebProcess::accessibilityAtspi()“ accessor — then “WebPageGtk.cpp“ can use “AccessibilityAtspi::singleton()”, and that seems the only place where the accessor is ever used. Of course we would still something like an “AccessibilityAtspi::initialize(const String& busAddress)” static method to configure the single instance from “::platformInitializeWebProcess()”. Thoughts?
Created attachment 448835 [details] Patch
Comment on attachment 448835 [details] Patch Thanks for the updated patch! I think it looks clearer now and I like it that now the fact that AccessibilityAtspi is a single instance is explicitly stated in the code :)
Committed r287876 (245920@trunk): <https://commits.webkit.org/245920@trunk>