Bug 234740 - [GTK][a11y] Defer the emission of AddAccessible signal with ATSPI
Summary: [GTK][a11y] Defer the emission of AddAccessible signal with ATSPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 234737
Blocks: ATSPI 234750 234781 234808
  Show dependency tree / graph
 
Reported: 2021-12-29 07:09 PST by Carlos Garcia Campos
Modified: 2022-01-12 04:02 PST (History)
11 users (show)

See Also:

Attachments
Patch (11.07 KB, patch)
2021-12-29 07:17 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (11.22 KB, patch)
2021-12-30 03:15 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (12.32 KB, patch)
2021-12-30 05:30 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (12.35 KB, patch)
2021-12-30 06:12 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (19.00 KB, patch)
2022-01-12 01:47 PST, Carlos Garcia Campos 		aperez: review+
aperez: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-12-29 07:09:02 PST 
In case of node added and removed quickly, we just avoid the emission of the signal.
Comment 1 Carlos Garcia Campos 2021-12-29 07:17:00 PST 
Created attachment 448071 [details]
Patch
Comment 2 Carlos Garcia Campos 2021-12-30 03:15:33 PST 
Created attachment 448090 [details]
Patch
Comment 3 Carlos Garcia Campos 2021-12-30 05:30:29 PST 
Created attachment 448094 [details]
Patch
Comment 4 Carlos Garcia Campos 2021-12-30 06:12:24 PST 
Created attachment 448095 [details]
Patch
Comment 5 Adrian Perez 2022-01-11 06:29:54 PST 
This needs a rebase now that the patch for bug #234737 has landed =)
Comment 6 Carlos Garcia Campos 2022-01-11 08:48:39 PST 
(In reply to Adrian Perez from comment #5)
> This needs a rebase now that the patch for bug #234737 has landed =)

Yes, but I noticed some issues that I'm trying to fix.
Comment 7 Adrian Perez 2022-01-11 13:13:08 PST 
(In reply to Carlos Garcia Campos from comment #6)
> (In reply to Adrian Perez from comment #5)
> > This needs a rebase now that the patch for bug #234737 has landed =)
> 
> Yes, but I noticed some issues that I'm trying to fix.

Awesome, thanks!
Comment 8 Carlos Garcia Campos 2022-01-12 01:47:35 PST 
Created attachment 448916 [details]
Patch
Comment 9 Adrian Perez 2022-01-12 03:31:35 PST 
Comment on attachment 448916 [details]
Patch

Patch LGTM with a small nit to fix before landing 👍️

View in context: https://bugs.webkit.org/attachment.cgi?id=448916&action=review

> Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp:-29
> -#include <wtf/NeverDestroyed.h>

Do not remove the line for <wtf/NeverDestroyed.h>, because it will break
non-unified builds.
Comment 10 Carlos Garcia Campos 2022-01-12 04:02:37 PST 
Committed r287918 (245951@trunk): <https://commits.webkit.org/245951@trunk>